Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to manage userOptions in dashboard.json #842

Closed
rgeniesse opened this issue Nov 13, 2017 · 7 comments · Fixed by #1018
Closed

Feature Request: Ability to manage userOptions in dashboard.json #842

rgeniesse opened this issue Nov 13, 2017 · 7 comments · Fixed by #1018

Comments

@rgeniesse
Copy link

Description of feature

Feature request for the ability to manage userOptions in dashboard.json.

Anything else to add that you think will be helpful?

While only called out in the Uchiwa (open source dashboard) documentation, I have shown on my own Enterprise Dashboard test server that adding these options are honored. The example here is requireSilencingReason only as that is all I am using now. The other options noted in the Uchiwa documentation at the end may be useful for others.

{ "dashboard": { "usersOptions": { "requireSilencingReason": true }, "host": "0.0.0.0", "port": 8443, "refresh": 60,

Uchiwa doc:
https://docs.uchiwa.io/getting-started/configuration/

@ghoneycutt
Copy link
Collaborator

Thanks for reporting! This might be more useful in the Uchiwa project itself at https://github.com/Yelp/puppet-uchiwa

@rgeniesse
Copy link
Author

Yes, I was sorta torn where to actually open it as the feature would span both projects. Uchiwa could use it, but this module covers the Sensu Enterprise Dashboard configuration already so felt like here was the best spot for my use case.

I don't know enough about these modules to know if it is solved in one place, that means it could be brought over to the other easily.

I'll gladly open one there too, but any contribution there would not be useful for Enterprise users. At least in my case, I don't have Uchiwa managed by a separate module or even installed standalone.

@ghoneycutt
Copy link
Collaborator

The sensu::enterprise::dashboard class should allow a hash of user defined data that is added to the dashboard.json config. This should work like the custom attribute for sensu::check.

https://github.com/sensu/sensu-puppet/blob/master/manifests/check.pp#L78

@ghoneycutt
Copy link
Collaborator

Released in v2.54.0

@ghost
Copy link

ghost commented Nov 20, 2018

Can you confirm this was implemented ? I don't see it in the code in version v2.58.0

@treydock
Copy link
Collaborator

@ninjasloth22 It appears this was not implemented.

@ghoneycutt ghoneycutt reopened this Nov 24, 2018
@ghoneycutt
Copy link
Collaborator

@treydock can you please investigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants