Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hasrestart & hasstatus to service management. #164

Merged
merged 4 commits into from
Mar 5, 2014
Merged

Add hasrestart & hasstatus to service management. #164

merged 4 commits into from
Mar 5, 2014

Conversation

rhoml
Copy link
Contributor

@rhoml rhoml commented Feb 24, 2014

No description provided.

@jlambert121
Copy link
Contributor

It looks like hasstatus is already true by default with 2.7, but hasrestart is false. I thought that one was true also. Could you remove the hasstatus parameter from these?

Looks like there are some lint warnings:
manifests/handler.pp:104:double_quoted_strings:WARNING:double quoted string containing no variables
manifests/plugin.pp:50:double_quoted_strings:WARNING:double quoted string containing no variables

and some travis spec errors - trailing commas on the hashes. I've done that one myself multiple times - habit to add them in modules, ruby 1.8.7 isn't quite as happy.

@rhoml
Copy link
Contributor Author

rhoml commented Feb 24, 2014

Will do in a couple of minutes.

@rhoml
Copy link
Contributor Author

rhoml commented Feb 24, 2014

@jlambert121 check it out

:enable => false
:ensure => 'stopped',
:enable => false,
:hasrestart => true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This trailing comma is upsetting travis (ruby 1.8.7 issue)

@jlambert121
Copy link
Contributor

Awesome - there's about 6 trailing commas in the spec total that are going to cause issues with the ruby 1.8.7 tests. Could you take those out so travis is happy, squish it into one commit and we'll merge! Thanks for the PR!

jlambert121 added a commit that referenced this pull request Mar 5, 2014
Add hasrestart & hasstatus to service management.
@jlambert121 jlambert121 merged commit 1cc4c2a into sensu:master Mar 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants