Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client keepalive cycling #232

Merged
merged 1 commit into from
Aug 28, 2014
Merged

Fix client keepalive cycling #232

merged 1 commit into from
Aug 28, 2014

Conversation

johnf
Copy link
Contributor

@johnf johnf commented Aug 23, 2014

keepalive wasn't in the check_args list so it would cycle on and off on
each puppet run

keepalive wasn't in the check_args list so it would cycle on and off on
each puppet run
jamtur01 added a commit that referenced this pull request Aug 28, 2014
@jamtur01 jamtur01 merged commit 287effb into sensu:master Aug 28, 2014
@bodgit
Copy link
Contributor

bodgit commented Sep 30, 2014

I'm fairly sure this change breaks the ability for the client to define any custom keepalive settings. Prior to this change you could do this:

class { 'sensu':
  …
  client_custom => {
    keepalive => {
      ...
    },
  },
  …
}

But by adding "keepalive" to check_args() and no other way to set that in the configuration they're pruned out.

bodgit added a commit to bodgit/sensu-puppet that referenced this pull request Oct 2, 2014
…cycle"

This reverts commit 287effb, reversing
changes made to dc74135.
@jamtur01
Copy link
Contributor

jamtur01 commented Oct 3, 2014

@johnf Any thoughts?

@johnf
Copy link
Contributor Author

johnf commented Oct 11, 2014

See my comment in #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants