Fix issue with array checking when no array present. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The introduction of issync? in the sensu_check type for the handlers and dependencies properties introduced an assumption that the values sourced are always arrays, yet :array_matching is set. In the event that an empty array is passed to the property within Puppet, Puppet will match this against an non-existing (nil) value and so will not write out the key/value pair on flush. When re-reading the file to analyze for changes, a nil value is loaded in return, but a NilClass has no sort method and so compilation of the catalog fails. This change sets the defaults within the type's JSON provider to always return an empty array unless something else is configured, preventing the issync? method from raising an exception on NilClass's.
|
Thanks! |
jlambert121
added a commit
that referenced
this pull request
Mar 20, 2015
Fix issue with array checking when no array present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of
issync?in thesensu_checktype for the handlers and dependencies properties introduced an assumption that the values sourced are always arrays, yet:array_matchingis set.In the event that an empty array is passed to the property within Puppet, Puppet will match this against an non-existing (
nil) value and so will not write out the key/value pair on flush. When re-reading the file to analyze for changes, anilvalue is loaded in return, but aNilClasshas nosortmethod and so compilation of the catalog fails.This change sets the defaults within the type's JSON provider to always return an empty array unless something else is configured, preventing the
issync?method from raising an exception onNilClasses.