Adding windows support.

[liamjbennett]

This should allow the user to be able to install the sensu client on
windows platforms.

[liamjbennett]

What are your general thoughts on this before I rebase?

[jlambert121]

Quickly skimming it I didn't see anything that was a concern, sorry I haven't spent more time on it though in detail. I will try to do that still this week.

[liamjbennett]

Ok, I will try and rebase this tomorrow.

[jlambert121]

Windows doesn't have the various sensu services?

[liamjbennett]

As far as I know and per the documentation I believe only the client is supported on windows.

[fessyfoo]

@liamjbennett this still issues. bump.

[portertech]

Would anyone care to have a go at fixing these Ruby 1.8.7 test failures?

1) sensu::plugin url defaults should contain Remote_file[https://raw.githubusercontent.com/sensu/sensu-community-plugins/master/plugins/system/check-mem.sh] with ensure => "present", path => "/etc/sensu/plugins/check-mem.sh" and checksum => "1d58b78e9785f893889458f8e9fe8627"

     Failure/Error: ) }

     Puppet::Error:

       Could not autoload puppet/type/remote_file: uninitialized constant FILE_PARAMS on node testing-worker-linux-docker-6f7dff96-3188-linux-5.prod.travis-ci.org

     # ./spec/defines/sensu_plugin_spec.rb:42

  2) sensu::plugin url setting params should contain Remote_file[https://raw.githubusercontent.com/sensu/sensu-community-plugins/master/plugins/system/check-mem.sh] with ensure => "present", path => "/var/sensu/plugins/check-mem.sh" and checksum => "1d58b78e9785f893889458f8e9fe8627"

     Failure/Error: ) }

     Puppet::Error:

       Could not autoload puppet/type/remote_file: uninitialized constant FILE_PARAMS on node testing-worker-linux-docker-6f7dff96-3188-linux-5.prod.travis-ci.org

     # ./spec/defines/sensu_plugin_spec.rb:57

[liamjbennett]

This is a problem with the upstream remote_file module. I have raised an issue for that here: lwf/puppet-remote_file#24

I have also attempted to monkey patch but thus been unsuccessful.

I would still prefer to use the remote_file module for this rather than archive because archive requires the faraday gem and that's just a pain to deal with.

[liamjbennett]

As per that issue it looks like 1.8.7 will not be supported so I need to look for an alternative if we are to continue to support 1.8.7 here.

I guess I could just switch back to the wget module and add a note the the README. Does that sound ok @portertech?

[portertech]

@liamjbennett it would seem that any alternative w/ 1.8 support is ideal to get this in 👍

[portertech]

@jlambert121 do we care about 1.8 anymore?

[jlambert121]

@portertech yeah, unfortunately we care about 1.8 support since puppet 3.x still being used on RHEL6 machines is 1.8-based. Puppet 4 goes to an embedded ruby similar to sensu, but puppet 4 isn't widely deployed at this point.

[liamjbennett]

I have been recently informed that the latest version of puppet-archive doesn't require the faraday gem any more and to my knowledge still has 1.8.x support. I will try and move forward with that and see how far I get

[portertech]

@liamjbennett awesome 👍 thanks.

[liamjbennett]

Just an update, I haven't had time to get back to this yet but in the mean time remote_file has been updated to support 1.8 so maybe I will go back and test this again.

[liamjbennett]

Ok @portertech the upstream remote_file dependency seems to have fixed the previous 1.8 issue and this is now working :)

[fessyfoo]

@portertech bump.

[jlambert121]

Thanks to everyone who has worked on this!