transorm input with munge in type rather than in sensu_check/json.rb provider #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test failures here will be fixed by #574 gem pinning |
|
@ttarczynski can you rebase this so the tests pass? |
1 similar comment
|
@ttarczynski can you rebase this so the tests pass? |
ttarczynski
force-pushed
the
sensu_check_refactor_3
branch
from
337899c to
4f1fa9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change follows the discussion in #535
I don't know how to properly test the provider functionality.
I think that spec tests in this module don't cover the provider implementation (only the type is tested by verifying the resulting catalog).