Add fix to resolve rabbitmq cluster heartbeat config failure. #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change seems 👍 to me, and 11a4769 itself will unblock a bunch of PRs currently failing due to changes in metadata-json-lint. @jaxxstorm any thoughts? |
Merged
This was referenced Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced by this change: #596
When a cluster is used the single node heartbeat var was conflicting with the cluster setting. This PR fixes that issue by mimicking what was done with the prefetch var.
The default is set to undef as I believe it should not be set by default. Sensu's documentation states that its default is to not be set which disables heartbeats and I would say we should follow that. The config example in the docs shows how to set it if needed: https://sensuapp.org/docs/latest/reference/rabbitmq.html#rabbitmq-attributes