support for redis as a transport

[RiRa12621]

this fixes #556

this work is heavily based on the work of @raffraffraff

this should be supported ASAP

[gutmensch]

LGTM

[lgarciaaco]

This is awesome!!

[cryptk]

This should probably say Sensu rather than Sense.

[RiRa12621]

maybe

[RiRa12621]

fixed

[cwjohnston]

Hi @RiRa12621, thanks for the pull request. This implementation seems reasonable, but I'd like to point out a few things for those following this PR.

• There are unresolved issues with the Redis transport which make it less than suitable for production, i.e. duplication of check requests. As a result we recommend the Redis transport be used only in testing and development scenarios.

• Sensu 0.19 is now almost two years old by now, and no longer available from the official Sensu package repositories. Anyone using a version prior to 0.23 is susceptible to Heartbleed, among other vulnerabilities.

• The next release of this module will include other changes already merged to master which are thought to be incompatible with Sensu versions prior 0.27.

With regard to the last two points, I think its reasonable to remove logic guarding redis transport on Sensu < 0.19 as that code will most likely never be exercised.

[RiRa12621]

Hey @cwjohnston,

• I read about the issue with the duplicate check requests but that should not prevent from implementing the option, since even if it’s only for testing an pre-prod, also those machines might be / are managed by config management (puppet in this case)
• even tho I am not a fan of making things backwards breaking, I see your point and can adjust that to remove Sensu < 0.19 support

[RiRa12621]

is there nay progress to be expected on this one ?
it’s been a month now

[raffraffraff]

A lot more, if you include the length of time they ignored my pull request... I am continuing to use my own fork. Good luck. On 24 May 2017 14:18, "Rick Rackow" <[email protected]> wrote: is there nay progress to be expected on this one ? it’s been a month now — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#639 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADOsBAKkYLJoSYEADWggx2j-VwN8-zljks5r9C4IgaJpZM4NAQm9> .

[RiRa12621]

true actually

[jaxxstorm]

I've merged this for you.

I want to make it clear why this took so long.

• This module is heavily relied on for people's monitoring systems. We have a responsibility to merge good code, and review it thoroughly. This takes time.
• This is a part time gig for me, I have a job that I need to do as well as maintain multiple open source projects

I understand the frustration here, but please try and be patient. I am not ignoring you.

[shajithravi]

@jaxxstorm any updates on this?