(#649) Enumerate sensu_enterprise_dashboard_config instances #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffmccune
force-pushed
the
649_se_dashboard_api_config_instances
branch
from
382bfab to
147bc99
Compare
|
What's with the empty commit? |
Made the empty commit to trigger Waffle so I'd be assigned the issue and it'd move over to in-progress. |
jeffmccune
force-pushed
the
649_se_dashboard_api_config_instances
branch
2 times, most recently
from
07e2abb to
ed64333
Compare
jeffmccune
changed the title
|
This is ready for review / merge. |
ghoneycutt
requested changes
Jul 7, 2017
spec/spec_helper.rb
Outdated
| @@ -1,4 +1,5 @@ | |||
| require 'puppetlabs_spec_helper/module_spec_helper' | |||
| require 'pry' | |||
There was a problem hiding this comment.
This should be removed. It is what's causing Travis to fail.
Gemfile
Outdated
| @@ -50,4 +50,8 @@ group :development do | |||
| gem 'listen', '~> 3.0.0', :require => false | |||
| end | |||
|
|
|||
| if File.exists? "#{__FILE__}.local" | |||
There was a problem hiding this comment.
This would be more clear if it read Gemfile.local instead of being variable, since the name of the Gemfile will not change.
|
Could you please add documentation of this new feature in the README. |
jeffmccune
force-pushed
the
649_se_dashboard_api_config_instances
branch
from
ed64333 to
dd3ad05
Compare
ghoneycutt
approved these changes
Jul 7, 2017
|
Thanks @jeffmccune Could you add the README portion and then this is good to go. |
jeffmccune
force-pushed
the
649_se_dashboard_api_config_instances
branch
3 times, most recently
from
e65f4c0 to
027ebf2
Compare
This patch implements the `instances` class method of the sensu_enterprise_dashboard_api_config json provider to enable `puppet resource` and resource purging using the resources resource. Maintenance changes include: * Add Gemfile.local to enable pry debugging. * Defensively access the catalog from the provider initializer. resolves sensu#649
jeffmccune
force-pushed
the
649_se_dashboard_api_config_instances
branch
from
027ebf2 to
5e1b0c4
Compare
|
@ghoneycutt README updated, review comments have been addressed. Should be ready for merge / release now. |
|
Released in v2.16.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the
resourcesresource cannot be used to purge unmanagedAPI endpoints as requested in #649. This patch implements the instances class
method providing this functionality.
resolves #649