Add confd_dir parameter #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bodgit Awesome work, thanks for contributing. We recently adopted Puppet 4 data types, could you please rebase against master. |
ghoneycutt
requested changes
Jul 19, 2017
| @@ -157,6 +158,11 @@ | |||
| it { should contain_file('/etc/default/sensu').with_content(%r{^PATH=/spec/tests$}) } | |||
| end | |||
|
|
|||
| context 'confd_dir => /spec/tests' do | |||
There was a problem hiding this comment.
Since confd_dir can be a string or array, we should test for both.
bodgit
force-pushed
the
confd_dir
branch
2 times, most recently
from
90ee862 to
1fb49d3
Compare
|
Updated to use an appropriate Puppet 4 data type and testing both single value and array of values. |
|
Apologies to ask again, but could you please rebase and squash your commits. I'll get this merged in next so there will not be any more conflicts. Thank you! |
|
Done. |
ghoneycutt
approved these changes
Jul 26, 2017
|
Thanks @bodgit !! Released in v2.29.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting
CONFD_DIRin/etc/default/sensuto be able to have multiple configuration directories. I have a use case where I want Puppet to create an additional configuration directory but not have it subject to the same management or purging rules as the default one. See sensu/sensu-omnibus#216 which explains why it's not the documentedCONFIG_DIRvariable.To keep my employers legal team happy, I have to include the following: