Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for #790 #800

Merged
merged 1 commit into from
Aug 23, 2017
Merged

Quick fix for #790 #800

merged 1 commit into from
Aug 23, 2017

Conversation

alvagante
Copy link
Collaborator

@alvagante alvagante commented Aug 21, 2017

Pull Request Checklist

This fixes #790

Description

Quick fix for #790.
If a file has to be created when $::sensu::rabbitmq_cluster is true , this should be totally safe and legit.

Fixes #790 .

Motivation and Context

How Has This Been Tested?

Not tested on real systems, just rake specs.

General

  • Update README.md with any necessary configuration snippets

  • New parameters are documented

  • New parameters have tests

  • Tests pass - bundle exec rake validate lint spec

@alvagante
Copy link
Collaborator Author

alvagante commented Aug 21, 2017

@agoddard sorry for delay in the reply.
My fix looks a bit too trivial to me to make me feel 100% comfortable about it and I have't tested this on a real Windows server, yet.
What's the expected behaviour when $::sensu::rabbitmq_cluster has some values (hash or array)?
If a file in $conf_dir/rabbitmq.json is expected, then this should be safe and enough.

@alvagante
Copy link
Collaborator Author

Successfully tested on Windows 2012R2

@agoddard
Copy link

@alvagante thanks! The expected behavior is as you suggest - as long as it's set and a file is present, it should avoid the current error (No such file or directory @ rb_sysopen - \etc\sensu\conf.d\rabbitmq.json)

Thanks!

@alvagante
Copy link
Collaborator Author

Ok, @ghoneycutt this is ready to merge

@ghoneycutt ghoneycutt merged commit 6d3c551 into sensu:master Aug 23, 2017
@ghoneycutt
Copy link
Collaborator

Thanks @alvagante !

Released in v2.33.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default linux path not working on Windows with $has_cluster
3 participants