Adding options to configure dir and file modes + tests #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghoneycutt
reviewed
Jan 16, 2018
manifests/init.pp
Outdated
| @@ -347,6 +353,14 @@ | |||
| Boolean $manage_mutators_dir = true, | |||
| Optional[String] $sensu_user = undef, | |||
| Optional[String] $sensu_group = undef, | |||
| Optional[String] $config_dir_mode = $::osfamily ? { | |||
There was a problem hiding this comment.
These should be Optional[Stdlib::Filemode].
|
PR looks great! Thank you! I added Stdlib::Filemode not long ago and transitioned the module to use it, so these should use that new type. https://github.com/puppetlabs/puppetlabs-stdlib/#stdlibfilemode |
|
Awesome, thanks for the quick feedback @ghoneycutt. Updated types to |
|
Thanks @jplindquist I'm closing this in favor of #869 where I just rebased your commits. |
|
Released in v2.49.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Adds 2 new options to manage config directory and file permissions
Description
Adds 2 new options (
config_dir_modeandconfig_file_mode) to enable management of directory and file permissions. Both options are optional and default to their existing settings depending on OS (Windows / other). If the new settings are undefined, there should be net zero changes to existing configs.Related Issue
Closes #825
Motivation and Context
Allow users to explicitly manage their own directory and file permissions to line up with other types of management systems where applicable (i.e. rpm packages)
How Has This Been Tested?
Ran spec tests before and after code changes, net zero changes unless config settings are present. Added new tests to verify settings when options are set.
General
Update
README.mdwith any necessary configuration snippetsNew parameters are documented
New parameters have tests
Tests pass -
bundle exec rake validate lint spec