Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #26

Merged
merged 5 commits into from
Feb 12, 2020
Merged

Refactoring #26

merged 5 commits into from
Feb 12, 2020

Conversation

palourde
Copy link
Contributor

@palourde palourde commented Feb 11, 2020

In summary:

  • Migrate from go dep to go modules
  • Migrate the build pipeline from Travis to Github Actions
  • Deprecate the old environment variables prefixed with SENSU_
  • Upgrade to sensu-plugin-sdk
  • Allow config options override via annotations and document it
  • Update the README using our latest template
  • Update the default icon URL to use our newest logo

I was able to successfully test the handler against Slack and it I don't believe it constitute a breaking change!

Screen Shot 2020-02-11 at 6 37 06 PM

Closes #21
Closes #20
Closes #18
Closes #17

Simon Plourde added 5 commits February 11, 2020 17:43
Signed-off-by: Simon Plourde <[email protected]>
Signed-off-by: Simon Plourde <[email protected]>
Signed-off-by: Simon Plourde <[email protected]>
@palourde palourde self-assigned this Feb 11, 2020
Copy link
Contributor

@echlebek echlebek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@palourde palourde merged commit d8c315c into master Feb 12, 2020
@palourde palourde deleted the refactoring branch February 12, 2020 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants