Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sentry 24.11.2 #1640

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

@kimxogus kimxogus force-pushed the feat/sentry-24.11.2 branch from ddb671c to 6947220 Compare December 17, 2024 11:35
@patsevanton
Copy link
Contributor

@kimxogus Maybe upgrade to first 24.10.0 ?

@kimxogus
Copy link
Contributor Author

@patsevanton My PR bumps sentry to fix security vulunability which was fixed in 24.11.1.
I've tested upgrading from 24.9.0 to 24.11.1 in my test environment. and it works fine

@patsevanton
Copy link
Contributor

@Mokto
Copy link
Contributor

Mokto commented Dec 23, 2024

The direct upgrade to 24.11 is fine. But yeah the tests need to pass.

@Mokto
Copy link
Contributor

Mokto commented Dec 23, 2024

👋 Hi, @kimxogus,
I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

@kimxogus kimxogus force-pushed the feat/sentry-24.11.2 branch from 6947220 to d46d8a8 Compare December 24, 2024 04:42
@patsevanton
Copy link
Contributor

After create new release #1648 i will create PR for update to https://github.com/getsentry/sentry/releases/tag/24.10.0

@kimxogus
Copy link
Contributor Author

snuba-migrate job fails with this error.
I'll write a separete PR to bump clickhouse

------------------------------------------------------------------------------------------------------------------------
==> Logs of container sentry-11zy8tpk85-snuba-migrate-2nztt
------------------------------------------------------------------------------------------------------------------------
snuba.migrations.errors.InvalidClickhouseVersion: Snuba requires minimum Clickhouse version 23.8.11.29 (sentry-11zy8tpk85-clickhouse:9000 - 23.3.19.32)
```

@akmalbaig98
Copy link

hey @kimxogus Please let me know, if this branch is working? Thank You.

@kimxogus kimxogus force-pushed the feat/sentry-24.11.2 branch from 7307063 to 2aa5d95 Compare December 30, 2024 04:20
@kimxogus
Copy link
Contributor Author

It works with current latest clickhouse chart. I'll update chart dependency when #1650 is released.

@madchap
Copy link

madchap commented Dec 31, 2024

Quickly tested as well (without changing values as presented in this PR), seems to run well (but I am not loaded yet, just deploying).

@kimxogus
Copy link
Contributor Author

kimxogus commented Jan 3, 2025

Test succeeded :)

@patsevanton
Copy link
Contributor

patsevanton commented Jan 3, 2025

@Mokto I created MR for update to Sentry 24.10.0:
#1652

@Mokto Mokto added the conflicts label Jan 3, 2025
@Mokto
Copy link
Contributor

Mokto commented Jan 3, 2025

👋 Hi, @kimxogus,
I detected conflicts against the base branch 🙊
You'll want to sync 🔄 your branch with upstream!

@patsevanton
Copy link
Contributor

@kimxogus Please remove topic snuba-metrics-summaries getsentry/snuba@24.10.0...24.11.2

@kimxogus
Copy link
Contributor Author

kimxogus commented Jan 6, 2025

All done

@patsevanton
Copy link
Contributor

@kimxogus
get and install

git clone https://github.com/kimxogus/sentry-charts.git
git checkout feat/sentry-24.11.2
helm install -n test --wait sentry . --values values.yaml --timeout=1000s

k get pod -n test | grep Error

sentry-snuba-migrate-2sv6x          0/1     Error       0             3m26s
sentry-snuba-migrate-45bxn          0/1     Error       0             6m8s
sentry-snuba-migrate-94z26          0/1     Error       0             8m34s
sentry-snuba-migrate-xch8s          0/1     Error       0             7m30s
sentry-snuba-migrate-xdrh5          0/1     Error       0             8m12s
sentry-snuba-migrate-xfm27          0/1     Error       0             8m47s
kubectl get pods -n test -o jsonpath='{range .items[*]}{.metadata.name}{"\t"}{.spec.containers[*].image}{"\n"}{end}'
sentry-clickhouse-0	clickhouse/clickhouse-server:23.3.19.32

@patsevanton
Copy link
Contributor

git clone https://github.com/kimxogus/sentry-charts.git
git checkout feat/sentry-24.11.2
helm dependency update
helm install -n test --wait sentry . --values values.yaml --timeout=1000s

k get pod -n test
NAME                                                              READY   STATUS    RESTARTS      AGE
sentry-billing-metrics-consumer-59b89fdcc6-t24c4                  1/1     Running   0             4m5s
sentry-clickhouse-0                                               1/1     Running   0             21m
sentry-cron-7d8d955b5-fgpc7                                       1/1     Running   3 (20m ago)   21m
sentry-generic-metrics-consumer-6cbf77dd56-f9mqp                  1/1     Running   0             4m4s
sentry-ingest-consumer-attachments-69cdd9578b-5qrh2               1/1     Running   0             4m3s
sentry-ingest-consumer-events-668575694c-fdk5x                    1/1     Running   0             4m2s
sentry-ingest-consumer-transactions-6c654ff5cf-4hpzr              1/1     Running   0             4m2s
sentry-ingest-monitors-db89f775d-8ss4g                            1/1     Running   0             4m1s
sentry-ingest-occurrences-78466b7d6-4wx7z                         1/1     Running   0             4m
sentry-ingest-replay-recordings-746f548f94-jq26b                  1/1     Running   0             3m59s
sentry-issue-occurrence-consumer-65d7ddc8fc-77745                 1/1     Running   0             3m43s
sentry-kafka-controller-0                                         1/1     Running   0             21m
sentry-kafka-controller-1                                         1/1     Running   0             21m
sentry-kafka-controller-2                                         1/1     Running   0             21m
sentry-metrics-consumer-65b4798b6d-2wxns                          1/1     Running   0             3m59s
sentry-nginx-78665d4559-7s8sj                                     1/1     Running   0             21m
sentry-post-process-forward-errors-7db9dd98c-5dzhw                1/1     Running   0             3m58s
sentry-post-process-forward-issue-platform-9fdf6f48-fzwm9         1/1     Running   0             3m57s
sentry-post-process-forward-transactions-64c5548cd6-xd96f         1/1     Running   0             3m56s
sentry-rabbitmq-0                                                 1/1     Running   0             21m
sentry-relay-5f76f76bb5-m84kk                                     1/1     Running   0             3m38s
sentry-sentry-postgresql-0                                        1/1     Running   0             21m
sentry-sentry-redis-master-0                                      1/1     Running   0             21m
sentry-sentry-redis-replicas-0                                    1/1     Running   0             21m
sentry-snuba-api-6bb8497c44-z8dhk                                 1/1     Running   0             21m
sentry-snuba-consumer-5d4756499-29zvf                             1/1     Running   0             3m56s
sentry-snuba-generic-metrics-counters-consumer-6fd69b54b9-9g6gz   1/1     Running   0             3m51s
sentry-snuba-generic-metrics-distributions-consumer-67988b4jkgt   1/1     Running   0             3m51s
sentry-snuba-generic-metrics-sets-consumer-8fb4f7685-dxqg2        1/1     Running   0             3m49s
sentry-snuba-group-attributes-consumer-7589c6f8b7-6f8nv           1/1     Running   0             3m48s
sentry-snuba-metrics-consumer-7dbc4f78d4-b2wff                    1/1     Running   0             3m47s
sentry-snuba-outcomes-billing-consumer-5d655dc766-qrdwg           1/1     Running   0             3m47s
sentry-snuba-outcomes-consumer-64cd5bd98d-xrhtm                   1/1     Running   0             3m42s
sentry-snuba-replacer-6dbbf449c6-wjhfh                            1/1     Running   0             3m41s
sentry-snuba-replays-consumer-57f6b8fdf6-msh4d                    1/1     Running   0             3m46s
sentry-snuba-spans-consumer-6445d7f8dc-pg6tt                      1/1     Running   0             3m45s
sentry-snuba-subscription-consumer-events-7964cf8559-c4hj5        1/1     Running   0             3m40s
sentry-snuba-subscription-consumer-metrics-bc9856864-5tllz        1/1     Running   0             3m40s
sentry-snuba-subscription-consumer-transactions-6f6f56959c9t6fj   1/1     Running   0             3m39s
sentry-snuba-transactions-consumer-58bb885f6f-8fnjf               1/1     Running   0             3m44s
sentry-subscription-consumer-events-749bdc8848-w4ftq              1/1     Running   0             3m55s
sentry-subscription-consumer-generic-metrics-cb94467fc-k8wxw      1/1     Running   0             3m54s
sentry-subscription-consumer-metrics-57f496f7b9-6ttcb             1/1     Running   0             3m53s
sentry-subscription-consumer-transactions-5689ddbb56-n9j8n        1/1     Running   0             3m52s
sentry-web-5f8bdbdd7f-qdxbj                                       1/1     Running   2 (20m ago)   21m
sentry-worker-6f99c5cbdb-v9m5t                                    1/1     Running   3 (20m ago)   21m
sentry-zookeeper-clickhouse-0                                     1/1     Running   0             21m

@kimxogus
Copy link
Contributor Author

kimxogus commented Jan 6, 2025

@patsevanton Can you show the error logs?

@patsevanton
Copy link
Contributor

@kimxogus like:

------------------------------------------------------------------------------------------------------------------------
==> Logs of container sentry-11zy8tpk85-snuba-migrate-2nztt
------------------------------------------------------------------------------------------------------------------------
snuba.migrations.errors.InvalidClickhouseVersion: Snuba requires minimum Clickhouse version 23.8.11.29 (sentry-11zy8tpk85-clickhouse:9000 - 23.3.19.32)

@kimxogus
Copy link
Contributor Author

kimxogus commented Jan 6, 2025

@patsevanton Clickhouse chart 3.14.0 has 23.8, and github action job also succeeded. I guess something is missing in your local environment.
This is the clickhouse image tag from the test job's log.
image

@kimxogus
Copy link
Contributor Author

kimxogus commented Jan 7, 2025

@Mokto Can you review this?

@patsevanton
Copy link
Contributor

Approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants