Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity detail is blank while waiting for graph api requests to complete #67

Closed
arawinters opened this issue Sep 30, 2019 · 2 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@arawinters
Copy link
Contributor

arawinters commented Sep 30, 2019

Describe the bug
Page spinner does not wait for entity detail to be fully rendered before disapearing. This results in the spinner disapearing right after a search result is clicked and then presenting a blank white page with a generic icon until all the component can be fully rendered.

To Reproduce
Steps to reproduce the behavior:

  1. Enter a name in search box
  2. Click on a name, the spinner will briefly appear.
  3. then wait another 10-XX seconds for the entity detail to render

Expected behavior
You click a name, spinner starts and when it dissapears the user is immediately presented with the entity detail for the result they clicked on.

Additional context
I'm 90% sure this bug was introduced when we either included the graph component, or when we broke the graph components out to a separate project/repo.

@arawinters
Copy link
Contributor Author

found the issue, it's not the graph api request. it's the withRelated=true part of the main entityId request. I have a fix for the UI spinner waiting until the request is actually complete, as for the speed of the request response, that's a separate issue.

proposed fix:
update this.sdkSearchService.getEntityById(entityId) to this.sdkSearchService.getEntityById(entityId, true) so that the route resolver request matches the request that is defined for the actual entity detail component.
https://github.com/Senzing/entity-search-web-app/blob/master/src/app/services/entity-search.service.ts#L142

@docktermj
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants