Adding E2E tests back in #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arawinters
added
test
kernelsam
approved these changes
Dec 6, 2024
docktermj
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request questions
Which issue does this address
resolves #581
Why was change needed
E2E tests had to be removed due to the Protractor runner being EOL'd a while back. We needed to choose a new Testing framework, port the old tests, re-enable CI running.
What does change improve
We can now safely allow depend-a-bot automatic minor version dependency updates. If some updated dependency borks something then hopefully the tests will break and it won't be allowed to auto merge to main.