Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#178 Remove TODO items #180

Merged
merged 7 commits into from
Feb 7, 2025
Merged

#178 Remove TODO items #180

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3df56e4
#178 Savepoint
docktermj Feb 6, 2025
1730031
#178 Savepoint
docktermj Feb 7, 2025
f2b5358
#178 Savepoint
docktermj Feb 7, 2025
1d1a667
#178 Savepoint
docktermj Feb 7, 2025
7352b82
#178 Savepoint
docktermj Feb 7, 2025
37331ae
#178 Savepoint
docktermj Feb 7, 2025
c978554
#178 Savepoint
docktermj Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/coverage/testcoverage.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,15 @@ local-prefix: "github.com/org/project"
threshold:
# (optional; default 0)
# The minimum coverage that each file should have
file: 85
file: 75

# (optional; default 0)
# The minimum coverage that each package should have
package: 85
package: 75

# (optional; default 0)
# The minimum total coverage project should have
total: 85
total: 75
# Holds regexp rules which will override thresholds for matched files or packages
# using their paths.
#
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ coverage: coverage-osarch-specific
.PHONY: check-coverage
check-coverage: export SENZING_LOG_LEVEL=TRACE
check-coverage:
@go test ./... -coverprofile=./cover.out -covermode=atomic -coverpkg=./...
@go test ./... -v -p 1 -coverprofile=./cover.out -covermode=atomic -coverpkg=./... ./...
@${GOBIN}/go-test-coverage --config=.github/coverage/testcoverage.yaml

# -----------------------------------------------------------------------------
Expand Down
14 changes: 7 additions & 7 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ require (
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/kr/text v0.2.0 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
golang.org/x/exp v0.0.0-20250128182459-e0ece0dbea4c // indirect
golang.org/x/net v0.33.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576 // indirect
google.golang.org/grpc v1.68.1 // indirect
google.golang.org/protobuf v1.35.2 // indirect
golang.org/x/exp v0.0.0-20250207012021-f9890c6ad9f3 // indirect
golang.org/x/net v0.34.0 // indirect
golang.org/x/sys v0.30.0 // indirect
golang.org/x/text v0.22.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250204164813-702378808489 // indirect
google.golang.org/grpc v1.70.0 // indirect
google.golang.org/protobuf v1.36.5 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
44 changes: 30 additions & 14 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,16 @@ github.com/aquilax/truncate v1.0.1/go.mod h1:BeMESIDMlvlS3bmg4BVvBbbZUNwWtS8uzYP
github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc h1:U9qPSI2PIWSS1VwoXQT9A3Wy9MM3WgvqSxFWenqJduM=
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
github.com/go-logr/logr v1.4.2 h1:6pFjapn8bFcIbiKo3XT4j/BhANplGihG6tvd+8rYgrY=
github.com/go-logr/logr v1.4.2/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY=
github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
github.com/go-logr/stdr v1.2.2/go.mod h1:mMo/vtBO5dYbehREoey6XUKy/eSumjCCveDpRre4VKE=
github.com/golang/protobuf v1.5.4 h1:i7eJL8qZTpSEXOPTxNKhASYpMn+8e5Q6AdndVa1dWek=
github.com/golang/protobuf v1.5.4/go.mod h1:lnTiLA8Wa4RWRcIUkrtSVa5nRhsEGBg48fD6rSs7xps=
github.com/google/go-cmp v0.6.0 h1:ofyhxvXcZhMsU5ulbFiLKl/XBFqE1GSq7atu8tAmTRI=
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/uuid v1.6.0 h1:NIvaJDMOsjHA8n1jAhLSgzrAzy1Hgr+hNrb57e+94F0=
github.com/google/uuid v1.6.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
Expand All @@ -27,20 +33,30 @@ github.com/senzing-garage/sz-sdk-go v0.14.5 h1:EbXg15KcrBUFiN7dyptHKye0UiMmG1ZaS
github.com/senzing-garage/sz-sdk-go v0.14.5/go.mod h1:wwLyt+FAF2xA3hWHjWkNOYvKZvjHxfHDvspTHA/Dtno=
github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOfJA=
github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
golang.org/x/exp v0.0.0-20250128182459-e0ece0dbea4c h1:KL/ZBHXgKGVmuZBZ01Lt57yE5ws8ZPSkkihmEyq7FXc=
golang.org/x/exp v0.0.0-20250128182459-e0ece0dbea4c/go.mod h1:tujkw807nyEEAamNbDrEGzRav+ilXA7PCRAd6xsmwiU=
golang.org/x/net v0.33.0 h1:74SYHlV8BIgHIFC/LrYkOGIwL19eTYXQ5wc6TBuO36I=
golang.org/x/net v0.33.0/go.mod h1:HXLR5J+9DxmrqMwG9qjGCxZ+zKXxBru04zlTvWlWuN4=
golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA=
golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/text v0.21.0 h1:zyQAAkrwaneQ066sspRyJaG9VNi/YJ1NfzcGB3hZ/qo=
golang.org/x/text v0.21.0/go.mod h1:4IBbMaMmOPCJ8SecivzSH54+73PCFmPWxNTLm+vZkEQ=
google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576 h1:8ZmaLZE4XWrtU3MyClkYqqtl6Oegr3235h7jxsDyqCY=
google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576/go.mod h1:5uTbfoYQed2U9p3KIj2/Zzm02PYhndfdmML0qC3q3FU=
google.golang.org/grpc v1.68.1 h1:oI5oTa11+ng8r8XMMN7jAOmWfPZWbYpCFaMUTACxkM0=
google.golang.org/grpc v1.68.1/go.mod h1:+q1XYFJjShcqn0QZHvCyeR4CXPA+llXIeUIfIe00waw=
google.golang.org/protobuf v1.35.2 h1:8Ar7bF+apOIoThw1EdZl0p1oWvMqTHmpA2fRTyZO8io=
google.golang.org/protobuf v1.35.2/go.mod h1:9fA7Ob0pmnwhb644+1+CVWFRbNajQ6iRojtC/QF5bRE=
go.opentelemetry.io/otel v1.32.0 h1:WnBN+Xjcteh0zdk01SVqV55d/m62NJLJdIyb4y/WO5U=
go.opentelemetry.io/otel v1.32.0/go.mod h1:00DCVSB0RQcnzlwyTfqtxSm+DRr9hpYrHjNGiBHVQIg=
go.opentelemetry.io/otel/metric v1.32.0 h1:xV2umtmNcThh2/a/aCP+h64Xx5wsj8qqnkYZktzNa0M=
go.opentelemetry.io/otel/metric v1.32.0/go.mod h1:jH7CIbbK6SH2V2wE16W05BHCtIDzauciCRLoc/SyMv8=
go.opentelemetry.io/otel/sdk v1.32.0 h1:RNxepc9vK59A8XsgZQouW8ue8Gkb4jpWtJm9ge5lEG4=
go.opentelemetry.io/otel/sdk v1.32.0/go.mod h1:LqgegDBjKMmb2GC6/PrTnteJG39I8/vJCAP9LlJXEjU=
go.opentelemetry.io/otel/sdk/metric v1.32.0 h1:rZvFnvmvawYb0alrYkjraqJq0Z4ZUJAiyYCU9snn1CU=
go.opentelemetry.io/otel/sdk/metric v1.32.0/go.mod h1:PWeZlq0zt9YkYAp3gjKZ0eicRYvOh1Gd+X99x6GHpCQ=
go.opentelemetry.io/otel/trace v1.32.0 h1:WIC9mYrXf8TmY/EXuULKc8hR17vE+Hjv2cssQDe03fM=
go.opentelemetry.io/otel/trace v1.32.0/go.mod h1:+i4rkvCraA+tG6AzwloGaCtkx53Fa+L+V8e9a7YvhT8=
golang.org/x/exp v0.0.0-20250207012021-f9890c6ad9f3 h1:qNgPs5exUA+G0C96DrPwNrvLSj7GT/9D+3WMWUcUg34=
golang.org/x/exp v0.0.0-20250207012021-f9890c6ad9f3/go.mod h1:tujkw807nyEEAamNbDrEGzRav+ilXA7PCRAd6xsmwiU=
golang.org/x/net v0.34.0 h1:Mb7Mrk043xzHgnRM88suvJFwzVrRfHEHJEl5/71CKw0=
golang.org/x/net v0.34.0/go.mod h1:di0qlW3YNM5oh6GqDGQr92MyTozJPmybPK4Ev/Gm31k=
golang.org/x/sys v0.30.0 h1:QjkSwP/36a20jFYWkSue1YwXzLmsV5Gfq7Eiy72C1uc=
golang.org/x/sys v0.30.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
golang.org/x/text v0.22.0 h1:bofq7m3/HAFvbF51jz3Q9wLg3jkvSPuiZu/pD1XwgtM=
golang.org/x/text v0.22.0/go.mod h1:YRoo4H8PVmsu+E3Ou7cqLVH8oXWIHVoX0jqUWALQhfY=
google.golang.org/genproto/googleapis/rpc v0.0.0-20250204164813-702378808489 h1:5bKytslY8ViY0Cj/ewmRtrWHW64bNF03cAatUUFCdFI=
google.golang.org/genproto/googleapis/rpc v0.0.0-20250204164813-702378808489/go.mod h1:8BS3B93F/U1juMFq9+EDk+qOT5CO1R9IzXxG3PTqiRk=
google.golang.org/grpc v1.70.0 h1:pWFv03aZoHzlRKHWicjsZytKAiYCtNS0dHbXnIdq7jQ=
google.golang.org/grpc v1.70.0/go.mod h1:ofIJqVKDXx/JiXrwr2IG4/zwdH9txy3IlF40RmcJSQw=
google.golang.org/protobuf v1.36.5 h1:tPhr+woSbjfYvY6/GPufUoYizxw1cF/yFoxJ2fmpwlM=
google.golang.org/protobuf v1.36.5/go.mod h1:9fA7Ob0pmnwhb644+1+CVWFRbNajQ6iRojtC/QF5bRE=
gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk=
gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q=
Expand Down
100 changes: 95 additions & 5 deletions szabstractfactory/szabstractfactory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,48 @@ Szabstractfactory is an implementation of the [senzing.SzAbstractFactory] interf
[senzing.SzAbstractFactory]: https://pkg.go.dev/github.com/senzing-garage/sz-sdk-go/senzing#SzAbstractFactory
*/
type Szabstractfactory struct {
AddConfigResult int64
AddDataSourceResult string
AddRecordResult string
CheckDatastorePerformanceResult string
CountRedoRecordsResult int64
CreateConfigResult uintptr
DeleteRecordResult string
ExportConfigResult string
ExportCsvEntityReportResult uintptr
ExportJSONEntityReportResult uintptr
FetchNextResult string
FindInterestingEntitiesByEntityIDResult string
FindInterestingEntitiesByRecordIDResult string
FindNetworkByEntityIDResult string
FindNetworkByRecordIDResult string
FindPathByEntityIDResult string
FindPathByRecordIDResult string
GetActiveConfigIDResult int64
GetConfigResult string
GetConfigsResult string
GetDataSourcesResult string
GetDatastoreInfoResult string
GetDefaultConfigIDResult int64
GetEntityByEntityIDResult string
GetEntityByRecordIDResult string
GetFeatureResult string
GetRecordResult string
GetRedoRecordResult string
GetStatsResult string
GetVirtualEntityByRecordIDResult string
HowEntityByEntityIDResult string
ImportConfigResult uintptr
GetLicenseResult string
PreprocessRecordResult string
ProcessRedoRecordResult string
ReevaluateEntityResult string
ReevaluateRecordResult string
SearchByAttributesResult string
GetVersionResult string
WhyEntitiesResult string
WhyRecordInEntityResult string
WhyRecordsResult string
}

// ----------------------------------------------------------------------------
Expand All @@ -35,7 +77,13 @@ Output
*/
func (factory *Szabstractfactory) CreateConfig(ctx context.Context) (senzing.SzConfig, error) {
_ = ctx
result := &szconfig.Szconfig{}
result := &szconfig.Szconfig{
AddDataSourceResult: factory.AddDataSourceResult,
CreateConfigResult: factory.CreateConfigResult,
ExportConfigResult: factory.ExportConfigResult,
GetDataSourcesResult: factory.GetDataSourcesResult,
ImportConfigResult: factory.ImportConfigResult,
}
return result, nil
}

Expand All @@ -51,7 +99,12 @@ Output
*/
func (factory *Szabstractfactory) CreateConfigManager(ctx context.Context) (senzing.SzConfigManager, error) {
_ = ctx
result := &szconfigmanager.Szconfigmanager{}
result := &szconfigmanager.Szconfigmanager{
AddConfigResult: factory.AddConfigResult,
GetConfigResult: factory.GetConfigResult,
GetConfigsResult: factory.GetConfigsResult,
GetDefaultConfigIDResult: factory.GetDefaultConfigIDResult,
}
return result, nil
}

Expand All @@ -67,7 +120,11 @@ Output
*/
func (factory *Szabstractfactory) CreateDiagnostic(ctx context.Context) (senzing.SzDiagnostic, error) {
_ = ctx
result := &szdiagnostic.Szdiagnostic{}
result := &szdiagnostic.Szdiagnostic{
CheckDatastorePerformanceResult: factory.CheckDatastorePerformanceResult,
GetDatastoreInfoResult: factory.GetDatastoreInfoResult,
GetFeatureResult: factory.GetFeatureResult,
}
return result, nil
}

Expand All @@ -83,7 +140,37 @@ Output
*/
func (factory *Szabstractfactory) CreateEngine(ctx context.Context) (senzing.SzEngine, error) {
_ = ctx
result := &szengine.Szengine{}
result := &szengine.Szengine{
AddRecordResult: factory.AddRecordResult,
CountRedoRecordsResult: factory.CountRedoRecordsResult,
DeleteRecordResult: factory.DeleteRecordResult,
ExportConfigResult: factory.ExportConfigResult,
ExportCsvEntityReportResult: factory.ExportCsvEntityReportResult,
ExportJSONEntityReportResult: factory.ExportJSONEntityReportResult,
FetchNextResult: factory.FetchNextResult,
FindInterestingEntitiesByEntityIDResult: factory.FindInterestingEntitiesByEntityIDResult,
FindInterestingEntitiesByRecordIDResult: factory.FindInterestingEntitiesByRecordIDResult,
FindNetworkByEntityIDResult: factory.FindNetworkByEntityIDResult,
FindNetworkByRecordIDResult: factory.FindNetworkByRecordIDResult,
FindPathByEntityIDResult: factory.FindPathByEntityIDResult,
FindPathByRecordIDResult: factory.FindPathByRecordIDResult,
GetActiveConfigIDResult: factory.GetActiveConfigIDResult,
GetEntityByEntityIDResult: factory.GetEntityByEntityIDResult,
GetEntityByRecordIDResult: factory.GetEntityByRecordIDResult,
GetRecordResult: factory.GetRecordResult,
GetRedoRecordResult: factory.GetRedoRecordResult,
GetStatsResult: factory.GetStatsResult,
GetVirtualEntityByRecordIDResult: factory.GetVirtualEntityByRecordIDResult,
HowEntityByEntityIDResult: factory.HowEntityByEntityIDResult,
PreprocessRecordResult: factory.PreprocessRecordResult,
ProcessRedoRecordResult: factory.ProcessRedoRecordResult,
ReevaluateEntityResult: factory.ReevaluateEntityResult,
ReevaluateRecordResult: factory.ReevaluateRecordResult,
SearchByAttributesResult: factory.SearchByAttributesResult,
WhyEntitiesResult: factory.WhyEntitiesResult,
WhyRecordInEntityResult: factory.WhyRecordInEntityResult,
WhyRecordsResult: factory.WhyRecordsResult,
}
return result, nil
}

Expand All @@ -99,7 +186,10 @@ Output
*/
func (factory *Szabstractfactory) CreateProduct(ctx context.Context) (senzing.SzProduct, error) {
_ = ctx
result := &szproduct.Szproduct{}
result := &szproduct.Szproduct{
GetLicenseResult: factory.GetLicenseResult,
GetVersionResult: factory.GetVersionResult,
}
return result, nil
}

Expand Down
Loading
Loading