Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repaint glitch in the gallery when managing bookmarks #2391

Closed
wladimirleite opened this issue Dec 30, 2024 · 2 comments · Fixed by #2392
Closed

Repaint glitch in the gallery when managing bookmarks #2391

wladimirleite opened this issue Dec 30, 2024 · 2 comments · Fixed by #2392
Assignees
Labels

Comments

@wladimirleite
Copy link
Member

When using the bookmark dialog to manage bookmarks (create a new bookmark, add the selected item to a bookmark etc.), after changes are made, the code calls App.repaintAllTableViews(), which contains a call to gallery.repaint(). Everything is updated as expected, except if a single item is selected in the gallery view. This selected item, if added to (or removed from) a bookmark, should be repainted to reflect the new bookmark colored icon. Somehow gallery.repaint() does not repaint the selected item. Although it is kind of random, it happens most of the time, so it is reproducible. If more than one item is selected, repaint works fine.

I have been noticing this issue for a while in real cases, but I am not sure when it started to happen (or if it has always been there). Anyway, I will submit a workaround to avoid this glitch.

@wladimirleite wladimirleite self-assigned this Dec 30, 2024
@wladimirleite
Copy link
Member Author

An example screenshot.
After creating a bookmark with a single selected item in the gallery view, its bookmark colored icon is not updated by the repaint() (in fact the selected cell repaint is not even called).
image

It should look like this:
image

By the way, just selecting any cell causes another repaint(), which works and updates the bookmarked cell.

@wladimirleite
Copy link
Member Author

A last observation, when using CTRL+Q/W to blur/enable black and white thumbs/image viewer, if a single cell is selected in the gallery view, sometimes it is not updated. This seems caused by the same issue (and should be fixed by the proposed workaround).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant