Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whatsapp quote messages #1920

Merged
merged 55 commits into from
Dec 28, 2023
Merged

Conversation

gfd2020
Copy link
Collaborator

@gfd2020 gfd2020 commented Oct 5, 2023

Implementation of WhatsApp quote messages.
Android Old DB - OK ( carved quotes fully implemented )
IPHONE - OK ( carved quotes NOT fully implemented )
Android New DB - OK ( carved quotes fully implemented )

@lfcnassif
Copy link
Member

Thank you @gfd2020!

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Nov 9, 2023

I get this template and make it work on iped. It is a html, css, javascript inner modal alert. Very cool.
https://www.cssscript.com/alert-confirm-modal-prompt/

It has confirm options too ...
What do you think?

image

@lfcnassif
Copy link
Member

Seems very nice!

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Nov 9, 2023

Seems very nice!

Good!

I'm almost done implementing it.
Do you think we need the window title? (this one in bold).
To give credit to the author (MIT license) do I include it in the source code or do I have to edit the license txt?

@lfcnassif
Copy link
Member

lfcnassif commented Nov 9, 2023

Do you think we need the window title? (this one in bold).

If removing it decreases the dialog size, I think we can stay without it, otherwise I would put a generic title like "Message" or "Warning".

To give credit to the author (MIT license) do I include it in the source code or do I have to edit the license txt?

Yes, please keep the copyright into the source if you copy it into the project, list the library in ThirdParty.txt file and copy its MIT license to licenses folder.

PS: Another advantage of using a javascript solution instead of a callback into java code is less exposure to possible security issues.

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Nov 9, 2023

If removing it decreases the dialog size, I think we can stay without it, otherwise I would put a generic title like "Message" or "Warning".

I think that way is better:
image

Yes, please keep the copyright into the source if you copy it into the project, list the library in ThirdParty.txt file and copy its MIT license to licenses folder.

Just copy link to the project page on javascript and css files.
I can´t find the MIT file on source page...

@gfd2020 gfd2020 marked this pull request as ready for review November 10, 2023 17:46
@gfd2020
Copy link
Collaborator Author

gfd2020 commented Nov 23, 2023

Hi @lfcnassif ,

Sorry to bother you. Were you able to redo the tests for this PR?

@lfcnassif
Copy link
Member

I'm really sorry @gfd2020, not yet, other things took my attention... I promise you the next new feature I'll focus on will be this (bug fixes may take priority). But I'll be very busy in the next days and weeks, including this weekend. I'll try to return to this next week in the night...

@gfd2020
Copy link
Collaborator Author

gfd2020 commented Nov 24, 2023

Hi @lfcnassif .

I see. Just take your time. No problem. I think removing bugs is more important. This PR will eventually be integrated at the right time.

@lfcnassif
Copy link
Member

Hi @gfd2020. I'm merging this right now to avoid more merge conflicts with WA parser improvements @wladimirleite currently is working on. I detected just very minor differences between this and master and I think this is very very good as is. I'll try to redo my tests later in January to confirm if my findings are really an issue or not. Thank you very much for this great feature!

@lfcnassif lfcnassif merged commit d10c9ac into sepinf-inc:master Dec 28, 2023
@wladimirleite
Copy link
Member

Thanks @lfcnassif!
After solving a couple of minor conflicts, I merged the master into the WA branch I am working on. This will avoid further conflicts.

@gfd2020, I just saw the generated HTML including the support to quote messages you implement, it looks really nice and will be very useful. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants