Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add child messages' parent to the 'Referenced by' tab #2285

Conversation

marcosammoura
Copy link
Contributor

Chats' Instant Messages and attachment messages, as processed by UFED parser, are not 'linked' to their parent chats and, therefore, their 'Referenced by' info are always empty. This makes it difficult, for instance, to spot messages of interest (e.g., outgoing, incoming) within the chat.

I propose some changes to add child messages' parent to the 'Referenced by' tab, making use of 'ufed:msgChildIds'
to find the parent item and 'ID' to allow for scrolling to the message within the chat, given that these messages do not have a hash.

@lfcnassif
Copy link
Member

lfcnassif commented Aug 16, 2024

Thank you @marcosammoura for this PR!

The behavior I wish since a long ago is displaying messages as children of the chat and the chat as children's parent. @aberenguel is trying to implement that in another PR, so the subitems and parent tabs would be used to display that relationship, but it is not simple due to IPED limitations. Ideally all chat parsers/results should have the same consistent behavior, it doesn't happen today.

One question: the "navigate to parent chat position" menu option on main table doesn't give you the same result? Not sure if I understood the benefit here...

@marcosammoura
Copy link
Contributor Author

@lfcnassif, answering your question, "navigate to parent chat position" already allows for scrolling to the message within the chat, indeed (in the 2nd paragraph of my original post I just meant to explain how I dealt with the situation).
One benefit of the proposal is to allow for fast selection of parent chat.

Concerning a consistent behavior across parsers, I completely agree on this and look forward to see the improvements that @aberenguel is working on.

@lfcnassif
Copy link
Member

lfcnassif commented Oct 17, 2024

Thanks @marcosammoura.

@aberenguel could you confirm PR #2287 will show instant messages imported from UFDR as children of conversations generated by UFEDChatParser? If yes and if @marcosammoura agrees, I think we can close this PR without merging, I think that behavior is better.

@aberenguel
Copy link
Contributor

Thanks @marcosammoura.

@aberenguel could you confirm PR #2287 will show instant messages imported from UFDR as children of conversations generated by UFEDChatParser? If yes and if @marcosammoura agrees, I think we can close this PR without merging, I think that behavior is better.

Yes, I confirm. It is like that:
image

@marcosammoura
Copy link
Contributor Author

Hey @lfcnassif and @aberenguel,

I completely agree the new behavior worked out by @aberenguel is much better and yes, I also think we can close this PR without merging.

@lfcnassif
Copy link
Member

Thank you @marcosammoura and sorry for not merging this, I really appreciate all your efforts very much! Thank you!

@lfcnassif lfcnassif closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants