Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShareazaDownloadParserTest for ShareazaDownloadParser #2339

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

ShareazaDownloadParserTest for ShareazaDownloadParser #2339

wants to merge 11 commits into from

Conversation

marcus6n
Copy link
Contributor

@marcus6n marcus6n commented Oct 15, 2024 •
edited
Loading

The ShareazaDownloadParserTest adds a test for the ShareazaDownloadParser class, ensuring it correctly parses download data and works reliably across different scenarios.

@marcus6n
Add initial test to ShareazaDownloadParser.java to validate download …
2816d31 
…metadata extraction
@marcus6n
Add test file for ShareazaDownloadParser
f5225f3
@marcus6n
Implement test case for ShareazaDownloadParser to validate parsing fu…
c7487bc 
…nctionality
@marcus6n
change Object handler
d433536
@marcus6n
change variable name
5661604
@marcus6n
reloading the test file with the correct encoding
4f6fb9a
@marcus6n
Extend ShareazaDownloadParserTest from TiffPageParserTest and call ge…
59ede25 
…tContext(filePath) directly.
@marcus6n
Add assertions to check presence of server details in HTS
670f497 
- Added assertTrue statements to verify the presence of various server details in the HTS output.
- Each line corresponds to specific attributes of the server, ensuring comprehensive testing of the server information.
@marcus6n
Removing some assertions to check presence of server details in HTS
8778280
@marcus6n marcus6n changed the title Add Logging to ShareazaDownloadParserTest for Debugging Header Issues ShareazaDownloadParserTest for ShareazaDownloadParser Oct 19, 2024
@marcus6n marcus6n requested a review from lfcnassif February 18, 2025 19:49
lfcnassif
lfcnassif requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@lfcnassif lfcnassif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marcus6n! Please also test for key-value pairs stored in the metadata object after the parser.parse(...) call.

lfcnassif
lfcnassif requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@lfcnassif lfcnassif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extending the TiffPageParserTest doesn't seem correct, please extend BaseItemSearchContext.

@marcus6n
Copy link
Contributor Author

All right, I'll adjust it properly.

@marcus6n marcus6n requested a review from lfcnassif February 19, 2025 18:05
@marcus6n
Copy link
Contributor Author

@lfcnassif I've made the changes you requested and added some more metadata tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfcnassif lfcnassif Awaiting requested review from lfcnassif

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcus6n @lfcnassif