Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] wrong type name in argument_parser error #2836

Merged
merged 1 commit into from
Sep 27, 2021
Merged

[FIX] wrong type name in argument_parser error #2836

merged 1 commit into from
Sep 27, 2021

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Sep 27, 2021 •
edited
Loading

Resolves #2835

@eseiler eseiler requested a review from Irallia September 27, 2021 14:05
@vercel
Copy link

vercel bot commented Sep 27, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/seqan/seqan3/2cXY4wca1651KypPb6QMgExzPuFv
✅ Preview: https://seqan3-git-fork-eseiler-fix-argparsetype-seqan.vercel.app

Irallia
Irallia approved these changes Sep 27, 2021
View reviewed changes
Copy link
Contributor

@Irallia Irallia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

@eseiler eseiler linked an issue Sep 27, 2021 that may be closed by this pull request
Wrong error message when trying to parse invalid values #2835
Closed
@marehr marehr requested review from a team and marehr and removed request for a team September 27, 2021 14:49
marehr
marehr approved these changes Sep 27, 2021
View reviewed changes
include/seqan3/argument_parser/detail/format_parse.hpp
@@ -451,7 +451,7 @@ class format_parse : public format_base
if (res == option_parse_result::error)
{
throw user_input_error{msg + "Argument " + input_value + " could not be parsed as type " +
get_type_name_as_string(input_value) + "."};
get_type_name_as_string(option_type{}) + "."};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is fine to assume default-constructible here.

Copy link
Member Author

@eseiler eseiler Sep 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the same, but then I saw

seqan3/include/seqan3/argument_parser/detail/format_parse.hpp

Line 380 in 055a3be

typename container_option_t::value_type tmp{};

(We assume default-constructible for the values inside arguments that are passed as list)
So I guess it's fine

@marehr marehr enabled auto-merge September 27, 2021 14:53
@Irallia Irallia mentioned this pull request Sep 27, 2021
Merged
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #2836 (1ffedbb) into release-3.1.0 (86bc503) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff               @@
##           release-3.1.0    #2836   +/-   ##
==============================================
  Coverage          98.21%   98.21%           
==============================================
  Files                272      272           
  Lines              10829    10829           
==============================================
  Hits               10636    10636           
  Misses               193      193
Impacted Files Coverage Δ
...ude/seqan3/argument_parser/detail/format_parse.hpp 96.71% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86bc503...1ffedbb. Read the comment docs.

@marehr marehr merged commit 393dfb1 into seqan:release-3.1.0 Sep 27, 2021
@eseiler eseiler deleted the fix/argparse_type branch September 27, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marehr marehr marehr approved these changes

@Irallia Irallia Irallia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong error message when trying to parse invalid values
3 participants
@eseiler @marehr @Irallia