Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] chunk_view using 16 bit integers #3014

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Jun 15, 2022

[...]: warning: conversion from ‘long long unsigned int’ to ‘uint16_t’ {aka ‘short unsigned int’} changes value from ‘10485760’ to ‘0’ [-Woverflow]
   65 |     for (auto && chunked_records : fin | seqan3::views::chunk((1ULL<<20)*10))

The draft says that chunk_size should be of type std::ranges::range_difference_t<rng_t> (it was also in range-v3), i.e., usually signed. This is probably for conversion signed<->unsigned.
It also states that chunk_size must be positive, though.

@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
seqan3 ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 2:25PM (UTC)

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Jun 15, 2022
@seqan-actions seqan-actions added the lint [INTERNAL] signal for linting label Jun 15, 2022
@seqan-actions seqan-actions removed the lint [INTERNAL] signal for linting label Jun 15, 2022
@SGSSGene SGSSGene self-requested a review June 15, 2022 14:24
@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #3014 (f64ed67) into master (d0c5249) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3014   +/-   ##
=======================================
  Coverage   98.21%   98.21%           
=======================================
  Files         275      275           
  Lines       12244    12245    +1     
=======================================
+ Hits        12025    12026    +1     
  Misses        219      219           
Impacted Files Coverage Δ
include/seqan3/utility/views/chunk.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c5249...f64ed67. Read the comment docs.

@eseiler eseiler merged commit 1148ce1 into seqan:master Jun 15, 2022
@eseiler eseiler deleted the fix/chunk branch June 15, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants