Fix/issue_3264 #3268
Merged
Fix/issue_3264 #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `seqan3::bitpacked_sequence`. seqan#3264 Further constraints the conversion constructors of the nucleotide and aminoacid base alphabet types to only consider conversion if all requirements are fulfilled. This is now represented by the specific concept `convertable_to_through_char_representation`. Through this proxy types will not be converted through their char representation but will be implicitly converted to their underling base alphabet type, e.g. dna4, and then copied/moved using the copy/move constructor of the underlying base alphabet type.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
seqan-actions
added
lint
eseiler
requested changes
Jul 16, 2024
Comment on lines
+7
to
+8
| #include <vector> | ||
|
|
There was a problem hiding this comment.
Suggested change
| #include <vector> |
Needed?
There was a problem hiding this comment.
Well, I am using a std::vector. It might be included by the helper.hpp already. Not including it has the potential that if some other code is refactored this test might not compile anymore since vector is not included through some dependent includes. Adding it makes clear, that I need it in the test.
But frankly, I don't care too much. What is the preferred policy here?
There was a problem hiding this comment.
Ah, didn't see the result_t. It's fine then
I answered on the issue page. |
rrahn
commented
Jul 16, 2024
seqan-actions
added
lint
eseiler
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further constraints the conversion constructors of the nucleotide and aminoacid base alphabet types to only consider conversion if all requirements are fulfilled. This is now represented by the specific concept
convertable_to_through_char_representation.Through this proxy types will not be converted through their char representation but will be implicitly converted to their underling base alphabet type, e.g. dna4, and then copied/moved using the copy/move constructor of the underlying base alphabet type.
Fixes #3264
Fixes #3267