Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Bump CMake #3314

Merged
merged 3 commits into from
Dec 13, 2024
Merged

[INFRA] Bump CMake #3314

merged 3 commits into from
Dec 13, 2024

Conversation

eseiler
Copy link
Member

@eseiler eseiler commented Dec 6, 2024

No description provided.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Dec 6, 2024
@seqan-actions
Copy link
Member

Documentation preview available at https://docs.seqan.de/preview/seqan/seqan3/3314

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.13%. Comparing base (8759edd) to head (df6bb22).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3314   +/-   ##
=======================================
  Coverage   98.13%   98.13%           
=======================================
  Files         271      271           
  Lines       11954    11954           
  Branches      104      104           
=======================================
  Hits        11731    11731           
  Misses        223      223           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Dec 6, 2024
It's only required for projects (CMakeLists.txt).
CPP23 detection needs 3.20, 3.10 and older will also be deprecated
@seqan-actions seqan-actions added lint [INTERNAL] signal for linting and removed lint [INTERNAL] signal for linting labels Dec 6, 2024
@eseiler eseiler mentioned this pull request Dec 6, 2024
@eseiler eseiler requested a review from rrahn December 13, 2024 14:41
@@ -2,7 +2,8 @@
# SPDX-FileCopyrightText: 2016-2024 Knut Reinert & MPI für molekulare Genetik
# SPDX-License-Identifier: BSD-3-Clause

cmake_minimum_required (VERSION 3.12...3.30)
# This line is required because this file is used in script mode (cmake -P).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Copy link
Contributor

@rrahn rrahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@rrahn rrahn merged commit 2d84062 into seqan:main Dec 13, 2024
42 checks passed
@eseiler eseiler deleted the infra/bump_cmake branch December 13, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants