Remove additional customisations from nf-core pipeline template to simplify further #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
drpatelh
commented
Nov 20, 2024
drpatelh
commented
- Replace nf-core mentions where relevant
- Add basic test fasta file with short protein sequence
- Add Seqera ANSI logo
- Remove excessive functions/calls in pipeline template
- Add basic docs to README
Comment on lines
-152
to
-161
| // Set bash options | ||
| process.shell = """\ | ||
| bash | ||
|
|
||
| set -e # Exit if a tool returns a non-zero status/exit code | ||
| set -u # Treat unset variables and parameters as an error | ||
| set -o pipefail # Returns the status of the last command to exit with a non-zero status or zero if all successfully execute | ||
| set -C # No clobber - prevent output redirection from overwriting files. | ||
| """ | ||
|
|
There was a problem hiding this comment.
out of curiosity, why are you removing this?
There was a problem hiding this comment.
Why is it there?! Why aren't we letting NF handle this?
FriederikeHanssen
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.