Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report for the command "sequelize db:seed:undo:all" #252

Closed
stuartZhang opened this issue Jan 25, 2016 · 7 comments
Closed

Bug Report for the command "sequelize db:seed:undo:all" #252

stuartZhang opened this issue Jan 25, 2016 · 7 comments

Comments

@stuartZhang
Copy link

stuartZhang commented Jan 25, 2016

Hello experts,

I have discovered the command "sequelize db:seed:undo:all" always complains the below error, even though there are the db records of the executed seeds.

Loaded configuration file "db/config.js".
Using environment "development".
Using gulpfile ~/usr/lib/node_modules/sequelize-cli/lib/gulpfile.js
Starting 'db:seed:undo:all'...

No seeders found.

And then, I looked into the source codes and observed an incorrect underlying API (from Umzug) is invoked in the 116th line of the JavaScript file "sequelize-cli/lib/tasks/db.js"

  'db:seed:undo:all': {
    descriptions: {
      'short': 'Deletes data from the database.',
      'long': [
        'The command tries unseeding every existing seed.'
      ]
    },
    task: function () {
      getMigrator('seeder', function (migrator) {

    migrator.pending() // The error is here. The expected API invocation is  "migrator.executed()"

    .then(function (seeders) {
      ...
    }).then(function () {
       ...
    })
    .catch(function (err) {
       ...
    });
  });
}

},

My question:

When will you fix the bug?

@Americas
Copy link
Collaborator

why not submit a PR?

@stuartZhang
Copy link
Author

I have just submitted a PR: #253

@corbanb
Copy link

corbanb commented Mar 14, 2016

+1 - bump

@wstallard-gobalto
Copy link

+1 Still broken...

@deviltsc
Copy link

deviltsc commented Aug 2, 2016

+1 Still broken

1 similar comment
@jamespedid
Copy link

+1 Still broken

@trjstewart
Copy link

+1 Still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants