The command "sequelize db:seed:undo:all" strikes, because an improper… #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly underlying Umzug API is invoked. 1. Umzug.prototype.pending() serves both db:migrate and db:seed. 2. Umzug.prototype.extecuted() serves both db:migrate:undo and db:seed:undo. Mimicking the handle of the command "db:migrate:undo", supersede "migrator.pending()" with "migrator.executed()".
| @@ -113,7 +113,7 @@ module.exports = { | |||
|
|
|||
| task: function () { | |||
| getMigrator('seeder', function (migrator) { | |||
| return migrator.pending() | |||
| return migrator.executed() | |||
There was a problem hiding this comment.
We need to handle both cases, for the case when there is no storage, pending is necessary, else executed is correct.
return (helpers.umzug.getStorage('seeder') === 'none'
? migrator.pending()
: migrator.executed())…pending is necessary, else executed is correct.
|
@stuartZhang Do you have plans to finish this pull request? |
|
Any updates? |
|
Any updates on this PR? |
Merged
codetriage-readme-bot
pushed a commit
to codetriage-readme-bot/cli
that referenced
this pull request
Jun 5, 2019
Add request and responses to debugging output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command "sequelize db:seed:undo:all" strikes, because an improperly underlying Umzug API is invoked.
Mimicking the handle of the command "db:migrate:undo", supersede "migrator.pending()" with "migrator.executed()".