Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glob v10 does not support Node 12 #659

Closed
mmkal opened this issue Mar 28, 2024 · 1 comment · Fixed by #660
Closed

Glob v10 does not support Node 12 #659

mmkal opened this issue Mar 28, 2024 · 1 comment · Fixed by #660
Labels
released

Comments

@mmkal
Copy link
Contributor

mmkal commented Mar 28, 2024

Originally posted by @WikiRik in #658 (comment)

Suggested fix: switch to fast-glob

glob has a helpful comparison section:

# Comparison to Other JavaScript Glob Implementations

If you want glob matching that is as faithful as possible to Bash pattern expansion semantics, and as fast as possible within that constraint, use this module.
If you are reasonably sure that the patterns you will encounter are relatively simple, and want the absolutely fastest glob matcher out there, use fast-glob.
If you are reasonably sure that the patterns you will encounter are relatively simple, and want the convenience of automatically respecting .gitignore files, use globby.
There are some other glob matcher libraries on npm, but these three are (in my opinion, as of 2023) the best.

I think it's pretty safe to assume the migration globs are simple enough for fast-glob to work for the vast majority of users. If not, they're hopefully advanced users and could always pass an array of migrations built via glob anyway.
@mmkal mmkal mentioned this issue Mar 28, 2024
Merged
mmkal added a commit that referenced this issue Mar 28, 2024
@mmkal
fix: restore node12 support (glob -> fast-glob) (#660)
b2a747c 
fixes #659

Note that there are some edge-case differences between glob and
fast-glob, but it's very unlikely that users of umzug will hit them.

See glob docs for an in-depth comparison:
https://github.com/isaacs/node-glob?tab=readme-ov-file#comparison-to-other-javascript-glob-implementations

If there's anyone that needs the old `glob` behaviour, they can use glob
themselves and pass an array of migrations to umzug. (see
https://github.com/sequelize/umzug#direct-migrations-list)
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024

Released in v3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: restore node12 support (glob -> fast-glob) sequelize/umzug
1 participant
@mmkal