Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fingerprinting of monero-serai by receiving funds #207

Closed
kayabaNerve opened this issue Jan 7, 2023 · 4 comments
Closed

Fingerprinting of monero-serai by receiving funds #207

kayabaNerve opened this issue Jan 7, 2023 · 4 comments
Labels
monero An issue with the Monero library/integration untested This issue, or its fix, needs testing to verify its accuracy

Comments

@kayabaNerve
Copy link
Member

Will monero-serai scan (or refuse to scan) TXs wallet2 won't? We need to review torsion handling, TX extra encoding support and more.

I can immediately cite monero-serai ignores secondary outputs, for a larger amount, when the burning bug is exploited. wallet2 will credit the difference, if the original output hasn't already been spent. This is a safety issue I won't budge on.

@kayabaNerve kayabaNerve added untested This issue, or its fix, needs testing to verify its accuracy monero An issue with the Monero library/integration labels Jan 7, 2023
@kayabaNerve
Copy link
Member Author

From #102, we always use u64 for our VarInts, when Monero is generic to them. That may be such an example of potential differences.

@kayabaNerve
Copy link
Member Author

I believe we test all keys from TX Extra. Monero only tests THE key and the additional key matching the output index: https://github.com/monero-project/monero/blob/master/src/cryptonote_basic/cryptonote_format_utils.cpp#L1047

@kayabaNerve
Copy link
Member Author

#235 and #236.

@kayabaNerve
Copy link
Member Author

Closing this as all known concerns are handled and any remainings should be documented/marked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monero An issue with the Monero library/integration untested This issue, or its fix, needs testing to verify its accuracy
Projects
None yet
Development

No branches or pull requests

1 participant