Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monero Library Tracking Issue #102

Closed
kayabaNerve opened this issue Aug 21, 2022 · 6 comments
Closed

Monero Library Tracking Issue #102

kayabaNerve opened this issue Aug 21, 2022 · 6 comments
Labels
discussion This requires discussion monero An issue with the Monero library/integration

Comments

@kayabaNerve
Copy link
Member

kayabaNerve commented Aug 21, 2022 •
edited
Loading

This is solely discussing the Monero library, and explicitly NOT the FROST aspects which are pending the IETF draft finalization and so on.

For all open issues: https://github.com/serai-dex/serai/issues?q=is%3Aopen+is%3Aissue+label%3Amonero

The following table is meant to go over all of them, along with other impactful issues.

Issue Required Status Notes
#104 No Not Started Potentially would never be used by anyone
#207 Yes Not Started
#210 No Not Started
#265 Yes Not Started
#266 Yes Awaiting Review
#273 No Not Started
#415 Yes Not Started
#478 Yes Not Started

If any issue is closed, it'll be removed from the table. If a new issue is created, it should be added.

Additional tasks:

  • Deser/ser all TXs/blocks on mainnet/testnet to ensure we can.

Additional requirements:

  • Remaining TODOs.
  • Extensive unit testing.
  • External review.

Additional notes:
@kayabaNerve kayabaNerve added discussion This requires discussion monero An issue with the Monero library/integration labels Aug 21, 2022
@kayabaNerve kayabaNerve mentioned this issue Aug 21, 2022
Closed
@kayabaNerve
Copy link
Member Author

kayabaNerve commented Aug 21, 2022 •
edited
Loading

This library has TODOs which also must be revisited. Moved into a new "Additional Tasks" section.

@kayabaNerve kayabaNerve changed the title Tracking issue for Monero library to be considered production ready Monero library Tracking Issue Aug 31, 2022
@kayabaNerve kayabaNerve changed the title Monero library Tracking Issue Monero Library Tracking Issue Aug 31, 2022
kayabaNerve added a commit that referenced this issue Sep 28, 2022
@kayabaNerve
Largely document the Monero libraries
983c107 
Relevant to #103 and likely 
sufficient to get this removed from 
#102.
kayabaNerve added a commit that referenced this issue Sep 28, 2022
@kayabaNerve
Initial documentation for the Monero libraries (#122)
fd48bbd 
* Document all features

* Largely document the Monero libraries

Relevant to #103 and likely 
sufficient to get this removed from 
#102.
@kayabaNerve kayabaNerve mentioned this issue Sep 29, 2022
Merged
This was referenced Jan 7, 2023
Closed
Closed
@kayabaNerve
Copy link
Member Author

8a24fc3 fixed an issue where scanned funds may be unspendable via monero-serai. This was possible to reach on the Monero mainnet due to some very specific protocol complexities, which we prior accommodated yet I missed the scanner didn't also accommodate.

Yanking all current releases accordingly.

@kayabaNerve
Copy link
Member Author

The newly added reserialize_chain binary ensures we can ser/deser all blocks/TXs. I'm running it now.

@kayabaNerve
Copy link
Member Author

We have .decompress calls when we should only use read_point as .decompress is less strict than read_point which matches Monero.

@kayabaNerve
Copy link
Member Author

We should test read_point for such cases...

@kayabaNerve kayabaNerve mentioned this issue Aug 21, 2023
Open
@j-berman j-berman mentioned this issue Jan 11, 2024
Merged
@kayabaNerve
Copy link
Member Author

Closing. Only #104 stands and the library is effectively at the 1.0 rc, being queued for audits. I don't believe the dedicated tracking issue here is better than the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion This requires discussion monero An issue with the Monero library/integration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kayabaNerve @TheArchitect108