Require serde >= 1.0.100 due to no_std-related Error re-export #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relevant Serde PR: serde-rs/serde#1620 To support both no-/std builds without using somewhat noisy conditional compilation directives, we implement the re-exported `serde::de::StdError` trait in serde-rs#606. However, this was only introduced in >= 1.0.100, so we need to bump the version requirement of serde. On the off chance of someone pulling in incompatible 1.0.4{5,6} versions of serde_json, I believe it'd be good to yank those and cut a new release with this patch. Sorry for the omission in the original PR. Fixes serde-rs#612.
dtolnay
approved these changes
Feb 7, 2020
|
I don't have anything to do with alt_serde. |
|
Oh, woops! I was sure you also published that, but now I can see that @cbeck88 is the publisher for alt crates. Sorry for the confusion! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Serde PR: serde-rs/serde#1620
To support both no-/std builds without using somewhat noisy
conditional compilation directives, we implement the re-exported
serde::de::StdErrortrait in #606.However, this was only introduced in >= 1.0.100, so we need to bump
the version requirement of serde.
On the off chance of someone pulling in incompatible 1.0.4{5,6} versions
of serde_json, I believe it'd be good to yank those and cut a new
release with this patch.
Sorry for the omission in the original PR.
Fixes #612.
@dtolnay By the way, is there a chance a new version of
alt_serde_*could be published? It'd help work around the Cargo feature bug, where accidentally pulling instdthrough build/dev dep forno_std/allocpackage breaks the build inno_stdconsumer crates.