impl Serialize and Deserialize for std::time::Duration #339
Assignees
Labels
Comments
tikue
changed the title
Serialize/Deserialize for std::time::Duration
|
Do you have a particular format in mind for this? |
|
I don't, but visiting the fields -- seconds and nanos -- seems like a reasonable option. |
|
This is included in Serde 0.8.1. |
|
That not very friendly format when you use in configuration |
pbeza
added a commit
to matter-labs/zksync-era
that referenced
this issue
Sep 6, 2024
Relevant logs from the `stage` environment showcasing the issue: https://grafana.matterlabs.dev/goto/IC-9k4eIR?orgId=1 Error message from the above logs: ``` Error: missing value for field initial_retry_backoff ``` The root cause of the problem supposedly boils down to the mismatch between the expected format of `TEE_PROVER_INITIAL_RETRY_BACKOFF` and the actual format. We export it as follows: ``` export TEE_PROVER_INITIAL_RETRY_BACKOFF=1 ``` which is not supported as explained here: serde-rs/serde#339 (comment)
4 tasks
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this issue
Sep 6, 2024
…y` config (#2817) ## What ❔ This PR fixes the deserialization issue of `std::time::Duration` in the `envy` configuration. Relevant logs from the `stage` environment showcasing the issue: https://grafana.matterlabs.dev/goto/IC-9k4eIR?orgId=1 Error message from the above logs: ``` Error: missing value for field initial_retry_backoff ``` The root cause of the problem supposedly boils down to the mismatch between the expected format of `TEE_PROVER_INITIAL_RETRY_BACKOFF` and the actual format. We export it as follows: ``` export TEE_PROVER_INITIAL_RETRY_BACKOFF=1 ``` which is not supported as explained here: serde-rs/serde#339 (comment) ## Why ❔ To fix the bug. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`.
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this issue
Sep 6, 2024
…y` config (#2817) ## What ❔ This PR fixes the deserialization issue of `std::time::Duration` in the `envy` configuration. Relevant logs from the `stage` environment showcasing the issue: https://grafana.matterlabs.dev/goto/IC-9k4eIR?orgId=1 Error message from the above logs: ``` Error: missing value for field initial_retry_backoff ``` The root cause of the problem supposedly boils down to the mismatch between the expected format of `TEE_PROVER_INITIAL_RETRY_BACKOFF` and the actual format. We export it as follows: ``` export TEE_PROVER_INITIAL_RETRY_BACKOFF=1 ``` which is not supported as explained here: serde-rs/serde#339 (comment) ## Why ❔ To fix the bug. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [ ] Tests for the changes have been added / updated. - [ ] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: