-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove public dependency on Syntex #358
Comments
This seems like a worthwhile compromise to me. I'm betting that the number of projects that use more than one compiler plugin on stable is pretty small. (My main project actually does, but it's nightly-only, so this wouldn't affect me.) |
Add serde_codegen::expand to avoid public Syntex dependency Required for #358. We can remove `serde_codegen::register` in the next breaking release. This allows Syntex users to avoid being broken by Serde bumping its Syntex dependency.
Add serde_codegen::expand to avoid public Syntex dependency Required for #358. We can remove `serde_codegen::register` in the next breaking release. This allows Syntex users to avoid being broken by Serde bumping its Syntex dependency.
The new |
As I mentioned in in the other thread, I'm all for getting rid of |
This removes the direct dependency on syntex, meaning plugins can bump their own versions independently (see serde-rs/serde#358)
Currently Syntex is a public dependency because the argument to
serde_codegen::register
is&mut syntex::Registry
:Let's see if we can do something more similar to this instead:
The downside would be if someone wants to apply more than one compiler plugin, their code is parsed multiple times:
The text was updated successfully, but these errors were encountered: