CIP: Integration of keccak256 into Plutus.
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquerejeta
reviewed
Jun 14, 2023
There was a problem hiding this comment.
This looks good. I think we can open the pr to cardano-foundation. The only requested change is the naming. You should use CIP-???? until a number is assigned (see here).
CIP-0382/README.md
Outdated
Comment on lines
44
to
61
| ### Costing of function | ||
| We performed some benchmarks (2,7 GHz Quad-Core Intel Core i7) on the `keccak256` that can be used to finalize the costing: | ||
| * Empty Input: | ||
| * `keccak256("")` -> N ms | ||
| * Short Fixed-Length Inputs (1, 2, 4, 8, 16, 32) | ||
| * `keccak256("a" ^ 1)` -> N ms | ||
| * `keccak256("a" ^ 2)` -> N ms | ||
| * `keccak256("a" ^ 4)` -> N ms | ||
| * `keccak256("a" ^ 8)` -> N ms | ||
| * `keccak256("a" ^ 16)` -> N ms | ||
| * `keccak256("a" ^ 32)` -> N ms | ||
| * Long Fixed-Length Inputs (256, 512, 1024) | ||
| * `keccak256("a" ^ 256)` -> N ms | ||
| * `keccak256("a" ^ 512)` -> N ms | ||
| * `keccak256("a" ^ 1024)` -> N ms | ||
| * Recursive hashing | ||
| * `keccak256(keccak256("a"))` -> N ms | ||
| * `keccak256(keccak256(keccak256("a")))` -> N ms |
There was a problem hiding this comment.
This can be removed. The costing will be handled in the future.
serejke
changed the title
keccak256 into Plutus.keccak256 into Plutus.
|
Filed: cardano-foundation#524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CIP proposes integration of
keccak256hash function to Plutus.