Check for legal page agreements upon authentication #318
Comments
julen
added a commit
to julen/zing
that referenced
this issue
Mar 26, 2018
There's not much use in having this as a setting and actually the approach should be revisited altogether. Refs. serge-community#318.
julen
added a commit
to julen/zing
that referenced
this issue
Mar 26, 2018
There's not much use in having this as a setting and actually the approach should be revisited altogether. Refs. serge-community#318.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current way legal page agreements are checked is highly inefficient, because a query is run on every non-xhr request for logged in users. This is implemented as a middleware.
This can be improved to check for such condition after users have been authenticated (both in normal and social accounts) but before signing them in. Modifying legal pages could invalidate existing sessions to force accepting any new/updated conditions, should that be needed
Going through a ToS acceptance flow should redirect users back to the page that signing in would redirect them to.
As a start, and to avoid confusion, the
LEGALPAGE_NOCHECK_PREFIXESsetting from staticpages can be moved to a constant.The text was updated successfully, but these errors were encountered: