Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test templates by comparing output with existing formatters #20

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

nblumhardt
Copy link
Member

I'm frequently pointing people to this library as a means to customize JSON output, with CompactJsonFormatter, RenderedCompactJsonFormatter, or JsonFormatter as the starting point.

This PR adds a test that attempts to replicate these formats byte-for-byte, so that we can identify gaps and inconsistencies.

Along the way:

…DateTime, Now, ToString; fixes wildcard comprehensions with unary conditions
@nblumhardt
Copy link
Member Author

🤔 PR isn't triggering CI; could be because I inadvertently PR'd from the repo itself? Going to live dangerously and see if I can get a build out of dev :-)

@nblumhardt nblumhardt merged commit 8a7a56c into dev Dec 22, 2020
@nblumhardt nblumhardt deleted the renderings-property branch December 22, 2020 05:15
@nblumhardt nblumhardt mentioned this pull request Mar 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Timestamp format on json template
1 participant