Add turbo-tests logo #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyazub
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Thank you, @dimitryzub 💯 I like this logo!
Please fix the link that build badge points to.
README.md
Outdated
|
|
||
| <div align="center"> | ||
|
|
||
| <a href=""></a> |
There was a problem hiding this comment.
This anchor tag points to https://github.com/serpapi/turbo_tests/blob/7fe028b9fb05447781ead9bf6c1817d46c71bb28 which is missing.
Why href equals to ""?
Suggested change
| <a href=""></a> | |
| [](https://github.com/serpapi/turbo_tests/actions/workflows/tests.yml) |
There was a problem hiding this comment.
I though plain markdown can't be wrapped by HTML (<div> in this case) and used <a> tag 🙂
I've added another commit, should be fixed now.
Update: I'll test with PNG logo instead and send you an example look.
|
@ilyazub What do you think about PNG instead of SVG? Example below: TurboTests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a logo for
turbo_tests, and centers tests workflow badge under the repo logo.Logo
width="500"could be adjusted. Currently (this PR), it looks something like this: