Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing dict files #176

Merged
merged 3 commits into from
Jan 22, 2023
Merged

Update existing dict files #176

merged 3 commits into from
Jan 22, 2023

Conversation

serpro69
Copy link
Owner

No description provided.

@serpro69 serpro69 added enhancement 🚀 New feature or request core 🧬 Issue related to :core module labels Jan 22, 2023
@serpro69 serpro69 added this to the 1.14.0 milestone Jan 22, 2023
@serpro69 serpro69 merged commit a2029b2 into master Jan 22, 2023
@serpro69 serpro69 deleted the update_data_provider branch January 22, 2023 18:24
@kukido
Copy link

kukido commented Mar 30, 2024

Looks like when country_code was removed from the address, then addresses generated with en-US are created with random country codes instead.

@Test
fun faker() {
    // 1.14.0 - broken
    // 1.13.0 - works
    val faker = Faker(
        fakerConfig { locale = "en-US" }
    )
    val address = faker.address
    assertThat(address.countryCode()).isEqualTo("US")
}
expected:<"[US]"> but was:<"[AF]">
Expected :"[US]"
Actual   :"[AF]"

@serpro69 serpro69 linked an issue Mar 31, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core 🧬 Issue related to :core module enhancement 🚀 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Random country code returned for address with locale en-US
2 participants