Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorthand http event syntax throws "Cannot read property 'toLowerCase' of undefined" #44

Closed
marcuswhybrow opened this issue Oct 11, 2016 · 4 comments

Comments

@marcuswhybrow
Copy link

serverless-webpack 1.0.0-rc.2 at this line assumes a serverless.yml event format like this:

functions:
  myfunction:
    handler: handlers.myfunction
    events:
      - http:
          method: POST       # method and path are
          path: myfunction   # defined as separate keys

However using the http event string shorthand...

functions:
  myfunction:
    handler: handlers.myfunction
    events:
      - http: POST myfunction

...throws the error...

Cannot read property 'toLowerCase' of undefined
... serverless-webpack/lib/serve.js:45:40 ...
marcuswhybrow pushed a commit to marcuswhybrow/serverless-webpack that referenced this issue Oct 11, 2016
marcuswhybrow pushed a commit to marcuswhybrow/serverless-webpack that referenced this issue Oct 11, 2016
@thenikso
Copy link
Contributor

PR #45 looks fine except the broken/missing tests. If we could sole those it would be a great addition

@schickling
Copy link

Any update on this?

@HyperBrain
Copy link
Member

We'll drop the serve command in favor of serverless-offline. See #152 and #135

@HyperBrain
Copy link
Member

serve will be removed in the next v3.0.0 release in favor of serverless-offline (see #152 ). No efforts will be spent on the function anymore. So I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants