Added tests for cleanup and updated test tools #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyperBrain
force-pushed
the
cleanup-unit-tests
branch
from
eaa7294 to
b59161d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #11
How did you implement it:
Updated all unit test tools and refactored the existing tests to use the new functionality. The serve tests are only partially updated, as they will be removed together with the serve command too - as well as the run tests.
How can we verify it:
run
npm testafter updating the dependencies withnpm install.Todos:
[ ] Write documentationFix linting errors (not yet implemented)Make sure code coverage hasn't dropped (not yet implemented)Is this ready for review?: YES
Is it a breaking change?: NO