Updated docs and message for aws-sdk dependency exclusion #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shavo007
reviewed
May 16, 2018
README.md
Outdated
| #### Runtime dependencies | ||
|
|
||
| If a runtime dependency is detected that is found in the `devDependencies` section and | ||
| so would not be packages, the plugin will error until you explicitly exclude it (see `forceExclude` below) |
|
@shavo007 I changed the warning to info and only show it in verbose mode now. Additionally fixed the docs. |
HyperBrain
changed the title
jamesmbourne
pushed a commit
to jamesmbourne/serverless-webpack
that referenced
this pull request
Oct 15, 2019
…-doc-for-new-dep-warning Updated docs and message for aws-sdk dependency exclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #393
Added paragraph to the README that explains the improved dependency validation.
Changed aws-sdk warning to informational message shown only with
--verboseHow did you implement it:
How can we verify it:
Todos:
Write testsFix linting errorsMake sure code coverage hasn't droppedProvide verification config / commands / resourcesIs this ready for review?: YES
Is it a breaking change?: NO