Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

docs: adds the build arg to Builder in CDK docs #908

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

kirkness
Copy link
Collaborator

Some background in @ibrahimcesar's comment here.

When running the builder with the defaults, e.g. new Builder('.', './build').build() the process will hang as the builder just runs next with no args, which in-turn starts the next dev server. Not sure whether this is intended or something has changed as I don't recall this behavior - high chance I've just forgotten. Either way, this PR just updates the docs to avoid confusion.

@kirkness kirkness mentioned this pull request Feb 28, 2021
7 tasks
@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #908 (7fce605) into master (83c8c6d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #908   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files          68       68           
  Lines        2488     2488           
  Branches      591      591           
=======================================
  Hits         2023     2023           
  Misses        398      398           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83c8c6d...7fce605. Read the comment docs.

@dphang dphang merged commit ab68a3e into master Mar 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the cdk-docs-build-example branch March 2, 2021 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants