Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Getting rid of rustc-serialize #506

Closed
3 tasks done
est31 opened this issue Jul 10, 2019 · 3 comments
Closed
3 tasks done

Getting rid of rustc-serialize #506

est31 opened this issue Jul 10, 2019 · 3 comments

Comments

@est31
Copy link
Contributor

est31 commented Jul 10, 2019 •
edited by nox
Loading

serde 1.0 has been around since over two years now, so I think one could think about removing rustc-serialize. I see two tasks:
This was referenced Jul 10, 2019
Closed
Merged
bors-servo pushed a commit that referenced this issue Jul 13, 2019
Auto merge of #507 - est31:remove_rustc_serialize_feature, r=SimonSapin
04e705d 
url crate: remove rustc-serialize optional dependency

Part of #506

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/507)
<!-- Reviewable:end -->
@est31 est31 mentioned this issue Jul 14, 2019
Merged
@est31
Copy link
Contributor Author

est31 commented Jul 15, 2019

@SimonSapin for idna, should I file a PR for the master or the 2.0 branch?

@SimonSapin
Copy link
Member

Anything that is not a breaking change of public API is fine in either. I’ll merge them before publishing 2.0.0.

bors-servo pushed a commit that referenced this issue Jul 15, 2019
Auto merge of #514 - est31:no_rustc_serialize, r=SimonSapin
f75aef7 
Make the tests use serde_json instead of rustc_serialize

Part of #506

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/514)
<!-- Reviewable:end -->
@est31 est31 mentioned this issue Jul 17, 2019
Merged
bors-servo pushed a commit that referenced this issue Jul 18, 2019
Auto merge of #518 - est31:idna_serde, r=nox
3c71cac 
Move tests of idna to serde-json

Part of #506

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/rust-url/518)
<!-- Reviewable:end -->
@nox
Copy link
Contributor

nox commented Jul 18, 2019

Thanks for your work, @est31!

@nox nox closed this as completed Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nox @SimonSapin @est31