Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Variables for Prefill Email and Computer Name #145

Closed
wants to merge 5 commits into from

Conversation

AndrewMBarnett
Copy link

  • Added variable fields for true or false in the prefill sections for email and computer name for the Welcome screen
  • Added email ending variable for custom email endings in your environment

dan-snelson and others added 5 commits February 11, 2024 08:19
Signed-off-by: Dan K. Snelson <[email protected]>
Signed-off-by: Dan K. Snelson <[email protected]>
Co-authored-by: Andrew Clark <[email protected]>
Co-authored-by: Andrew Spokes <[email protected]>
Added variable field for prefill email and computer name.
Added variable fields for true or false in the prefill sections for email and computer name
@dan-snelson dan-snelson changed the base branch from main to 1.15.0 April 3, 2024 12:42
@dan-snelson
Copy link
Collaborator

Thanks for the PR, @AndrewMBarnett.

If this does merged, it'd be included in version 1.15.0.

I just changed the base branch and now there are conflicts; please review.

@AndrewMBarnett
Copy link
Author

Hi @dan-snelson.

For the conflicts, are you wanting me to add my changes to the files listed with conflicts? Just want to make sure I resolve the correct conflicts.

@dan-snelson
Copy link
Collaborator

Sorry for any Dan-induced confusion, Andrew; please just add your changes to Setup-Your-Mac-via-Dialog.bash.

@AndrewMBarnett
Copy link
Author

Hey Dan, I don't know if I have access to add anything?

Is this what you are looking for or are do you want the actual script edits?

Version 1.15.0, 02-Apr-2024

- Added variables for prefill Email and Computer Name Fields for the Welcome dialog screen (thanks, @AndrewMBarnett)Pull Request No. 145

@dan-snelson
Copy link
Collaborator

Greetings, @AndrewMBarnett!

Will you please pull the 1.15.0 branch a re-re-submit only Setup-Your-Mac-via-Dialog.bash one last time ?

(If it still doesn't behave, I can manually add your changes, but I'm not enough of a git Ninja-Jedi to give you the deserved credit.)

Thanks.

@dan-snelson
Copy link
Collaborator

@AndrewMBarnett:

Your changes have been included in 1.15.0-b12.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants