Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Your Mac (1.14.3) #150

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Setup Your Mac (1.14.3) #150

merged 2 commits into from
Jun 7, 2024

Conversation

dan-snelson
Copy link
Collaborator

Improves exit code processing for the Welcome dialog (for compatibility with swiftDialog 2.5.0).

@dan-snelson
1.14.3
b2ebdd0 
Signed-off-by: Dan K. Snelson <[email protected]>
@TechTrekkie
Copy link
Contributor

Hey @dan-snelson , line 2920 calls a logComment function but the function doesn't exist.
Other than that, everything appears to be functioning as expected.
Is expected to still work with 2.4.2 or should the minimum be 2.5.0?

@dan-snelson
1.14.3
adc9514 
Signed-off-by: Dan K. Snelson <[email protected]>
@dan-snelson
Copy link
Collaborator Author

Noice catch, @TechTrekkie! Fixed Line 2920. (The logComment function is introduced in SYM 1.15.0, from which this fix was back-ported.)

SYM 1.14.3 is compatible with — but doesn't require — swiftDialog 2.5.0.

@dan-snelson dan-snelson merged commit 30a1573 into main Jun 7, 2024
1 check passed
@dan-snelson dan-snelson deleted the 1.14.3 branch June 7, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TechTrekkie TechTrekkie TechTrekkie approved these changes

@drtaru drtaru Awaiting requested review from drtaru

@robjschroeder robjschroeder Awaiting requested review from robjschroeder

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dan-snelson @TechTrekkie