Reduce number of calls to TObjArray->At and TObjArray->operator[]

* TObjArray->operator[] is a virtual function call; replaced this in critical places by TObjArray->UncheckedAt() * equally replaced TObjArray->At() by TObjArray->UncheckedAt() in some critical places
sevdokim · Jul 6, 2016 · 0557dfe · 0557dfe
1 parent 0564e32
commit 0557dfe
Show file tree

Hide file tree

Showing 5 changed files with 19 additions and 13 deletions.
diff --git a/EMCAL/EMCALbase/AliEMCALSDigitizer.cxx b/EMCAL/EMCALbase/AliEMCALSDigitizer.cxx
@@ -296,7 +296,7 @@ void AliEMCALSDigitizer::Digitize(Option_t *option)
           Int_t nHit = fHits->GetEntriesFast();
           for(iHit = 0; iHit< nHit;iHit++){
 
-            AliEMCALHit * hit = dynamic_cast<AliEMCALHit*>(fHits->At(iHit)) ;
+            AliEMCALHit * hit = static_cast<AliEMCALHit*>(fHits->UncheckedAt(iHit)) ;
             AliEMCALDigit * curSDigit = 0 ;
             AliEMCALDigit * sdigit = 0 ;
             Bool_t newsdigit = kTRUE; 
@@ -325,7 +325,7 @@ void AliEMCALSDigitizer::Digitize(Option_t *option)
 
               if(curSDigit != 0){
                 for(Int_t check= 0; check < nSdigits ; check++) {
-                  sdigit = dynamic_cast<AliEMCALDigit *>(sdigits->At(check)) ;
+                  sdigit = static_cast<AliEMCALDigit *>(sdigits->UncheckedAt(check)) ;
                   if(sdigit){
                     if( sdigit->GetId() == curSDigit->GetId()) { // Are we in the same ECAL tower ?              
                       *sdigit = *sdigit + *curSDigit;
@@ -360,7 +360,7 @@ void AliEMCALSDigitizer::Digitize(Option_t *option)
 				fSDigitsInRun += nSdigits ;  
 
 				for (iSDigit = 0 ; iSDigit < sdigits->GetEntriesFast() ; iSDigit++) { 
-					AliEMCALDigit * sdigit = dynamic_cast<AliEMCALDigit *>(sdigits->At(iSDigit)) ;
+                    AliEMCALDigit * sdigit = static_cast<AliEMCALDigit *>(sdigits->UncheckedAt(iSDigit)) ;
 					if(sdigit)sdigit->SetIndexInList(iSDigit) ;
           else AliFatal("sdigit is NULL!");
 				}	

diff --git a/ITS/ITSsim/AliITSDetTypeSim.cxx b/ITS/ITSsim/AliITSDetTypeSim.cxx
@@ -334,7 +334,7 @@ AliITSsegmentation* AliITSDetTypeSim::GetSegmentationModel(Int_t dettype) const{
        Warning("GetSegmentationModel","fSegmentation is 0!");
        return 0; 
    } 
-   return (AliITSsegmentation*)(fSegmentation->At(dettype));
+   return (AliITSsegmentation*)(fSegmentation->UncheckedAt(dettype));
 }
 //_______________________________________________________________________
 AliITSsegmentation* AliITSDetTypeSim::GetSegmentationModelByModule(Int_t module) const{

diff --git a/STEER/STEER/AliMC.cxx b/STEER/STEER/AliMC.cxx
@@ -1008,7 +1008,7 @@ void AliMC::PreTrack()
      AliModule *module;
 
      for (Int_t i = 0; i <= gAlice->GetNdets(); i++)
-       if ((module = static_cast<AliModule *>(dets[i])))
+       if ((module = static_cast<AliModule *>(dets.UncheckedAt(i))))
          module->PreTrack();
 }
 
@@ -1074,7 +1074,7 @@ void AliMC::Stepping()
     }
 
     //Call the appropriate stepping routine;
-    AliModule *det = static_cast<AliModule*>(gAlice->Modules()->At(id));
+    AliModule *det = static_cast<AliModule*>(gAlice->Modules()->UncheckedAt(id));
     if(det && det->StepManagerIsEnabled()) {
       det->StepManager();
     }
@@ -1299,7 +1299,7 @@ void AliMC::PostTrack()
   AliModule *module;
 
   for(Int_t i=0; i<=gAlice->GetNdets(); i++)
-    if((module = static_cast<AliModule*>(dets[i])))
+    if((module = static_cast<AliModule*>(dets.UncheckedAt(i))))
       module->PostTrack();
 }
 

diff --git a/STEER/STEER/AliQADataMaker.cxx b/STEER/STEER/AliQADataMaker.cxx
@@ -528,7 +528,10 @@ Int_t AliQADataMaker::FillData(TObjArray ** list, Int_t index, double x)
   int count = 0;
   if (arr) {
     count = arr->GetEntriesFast();
-    for (int ih=count;ih--;) if ((TH1*)arr->At(ih)) ((TH1*)arr->At(ih))->Fill(x);
+    for (int ih=count;ih--;){
+      TH1 *histo = (TH1*)arr->UncheckedAt(ih);
+      if (histo) histo->Fill(x);
+    }
   }
   return count;
 }
@@ -541,7 +544,10 @@ Int_t AliQADataMaker::FillData(TObjArray ** list, Int_t index, double x, double
   int count = 0;
   if (arr) {
     count = arr->GetEntriesFast();
-    for (int ih=count;ih--;) if ((TH1*)arr->At(ih)) ((TH1*)arr->At(ih))->Fill(x,y);
+    for (int ih=count;ih--;){
+      TH1 *histo=(TH1*)arr->UncheckedAt(ih);
+      if (histo) histo->Fill(x,y);
+    }
   }
   return count;
 }
@@ -680,8 +686,8 @@ TH1* AliQADataMaker::GetData(TObjArray ** list, const Int_t index, int cloneID)
   if (!data) return 0;
   Bool_t orig = cloneID<0 || cloneID==GetNTrigClasses();
   if (data->TestBit(AliQAv1::GetClonedBit())) {
-    if (orig) return data->TestBit(AliQAv1::GetOrigHistoKeptBit()) ? (TH1*)((TObjArray*)data)->At(GetNTrigClasses()) : 0;
-    else      return (TH1*)((TObjArray*)data)->At(cloneID); // there was a cloning
+    if (orig) return data->TestBit(AliQAv1::GetOrigHistoKeptBit()) ? (TH1*)((TObjArray*)data)->UncheckedAt(GetNTrigClasses()) : 0;
+    else      return (TH1*)((TObjArray*)data)->UncheckedAt(cloneID); // there was a cloning
   }
   //
   // not cloned, is the original histo requested?

diff --git a/TPC/TPCsim/AliTPCTrackHitsV2.cxx b/TPC/TPCsim/AliTPCTrackHitsV2.cxx
@@ -762,14 +762,14 @@ Bool_t AliTPCTrackHitsV2::Next()
 
   fCurrentHit->SetStackIndex(fCurrentHit->GetStackIndex()+1);
 
-  AliTrackHitsParamV2 *param =  (AliTrackHitsParamV2 *)fArray->At(fCurrentHit->GetParamIndex());
+  AliTrackHitsParamV2 *param =  (AliTrackHitsParamV2 *)fArray->UncheckedAt(fCurrentHit->GetParamIndex());
   if (fCurrentHit->GetStackIndex()>=param->GetNHits()){
     fCurrentHit->SetParamIndex(fCurrentHit->GetParamIndex()+1);
     if (fCurrentHit->GetParamIndex()>=fArray->GetEntriesFast()){
       fCurrentHit->SetStatus(kFALSE);
       return kFALSE;
     }
-    param =  (AliTrackHitsParamV2 *)fArray->At(fCurrentHit->GetParamIndex());
+    param =  (AliTrackHitsParamV2 *)fArray->UncheckedAt(fCurrentHit->GetParamIndex());
     fCurrentHit->SetStackIndex(0); 
     fCurrentHit->SetR(param->GetR());
   }