Skip to content

Commit

Permalink
ALIROOT-5678 fix (potential) floating point exceptions
Browse files Browse the repository at this point in the history
When reading HLT clusters during TPC reconstruction, some clusters end up
with non-sense values rendering them unusable, and, worst-case, lead to a
FPE. This is assumingly caused by a gcc bug when inlining
AliHLTTPCHWClusterMerger::iterator::operator*()
and hence affects all merged clusters. This can be prevented by forcing gcc
not to inline (e.g. attribute noinline), by using clang, or by this very patch.
  • Loading branch information
tbreitne authored and hristov committed Oct 27, 2014
1 parent 22a4b84 commit bdc2569
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion HLT/TPCLib/HWCFemulator/AliHLTTPCHWClusterMerger.h
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class AliHLTTPCHWClusterMerger : public AliHLTLogging
}
~iterator() {}

AliClusterRecord operator*() {return *fIter;}
AliClusterRecord& operator*() {return *fIter;}

// prefix operators
iterator& operator++() {
Expand Down

0 comments on commit bdc2569

Please sign in to comment.