Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont swallow exceptions when there is no message #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dont swallow exceptions when there is no message #15

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2692db3
dont swallow exceptions when there is no message
togakangaroo Aug 15, 2016
ed862ba
simple tester project that can write to the surge graylog instance
togakangaroo Jun 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
dont swallow exceptions when there is no message
@togakangaroo
togakangaroo committed Aug 15, 2016

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 2692db37ab1ae587ef349b69061c85017b24f77c
2 changes: 1 addition & 1 deletion Target/GelfConverter.cs
View file
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ public JObject GetGelfJson(LogEventInfo logEventInfo, string facility)
{
//Retrieve the formatted message from LogEventInfo
var logEventMessage = logEventInfo.FormattedMessage;
if (logEventMessage == null) return null;
if (logEventMessage == null && logEventInfo.Exception == null) return null;

//If we are dealing with an exception, pass exception properties to LogEventInfo properties
if (logEventInfo.Exception != null)