This repository has been archived by the owner on Jun 5, 2020. It is now read-only.
Add -d option for finding duplicates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if flag_duplicates { | ||
| let dups = find_duplicates(&graph); | ||
| if dups.len() == 0 { | ||
| println!("No package name is imported more than once"); |
There was a problem hiding this comment.
I would lean towards leaving this out personally - things like cargo build produce no output if there's nothing to do.
|
This seems cool! One little comment but lgtm otherwise. |
Cargo has problems with finding optimal set of packages to download. Sometimes this will result in multiple versions of the same dependency being applied in the same project and lead to cryptic errors. -d option will find all packages using the same name. If they exist in more than one version, they'll be printed out in the "inverted" mode, showing where did they get imported.
|
Fixed now. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo has problems with finding optimal set of packages to download. Sometimes
this will result in multiple versions of the same dependency being applied in
the same project and lead to cryptic errors. (rust-lang/cargo#2064)
-d option will find all packages using the same name. If they exist in more than
one version, they'll be printed out in the "inverted" mode, showing where did
they get imported.